Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove broken links from 'In the wild' #1800

Merged
merged 2 commits into from Feb 21, 2024

Conversation

BrianCurrie
Copy link
Contributor

馃摑 Documentation

  • Remove two broken demo links from 'In the wild' section

@BrianCurrie
Copy link
Contributor Author

Slack link seems dead too #1801

@williaster
Copy link
Collaborator

Thanks @BrianCurrie 馃檹 And yes the d3 slack channel hasn't been monitored / used well (and has limitations with messages expiring since they use the free plan).

Any interest in replacing that link in this PR with visx discussions which we now use instead? https://github.com/airbnb/visx/discussions

@BrianCurrie
Copy link
Contributor Author

@williaster no worries! I went ahead and pushed the updated link to discussions.

I noticed the Travis CI build status badge seems to be breaking. I'm getting some text decoration between the links below which may be unintended too. Willing to add an update for those in this PR if that would work for you?

chrome_WLtNTyjogi

@williaster
Copy link
Collaborator

Hey @BrianCurrie CI should be running for the PR now, I'd be surprised if it failed. for first-time contributors to a project, CI has to be approved to run - sorry for the delay! thanks for the slack => discussions update 馃檹

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good, thanks again!

@williaster williaster merged commit 6edbde4 into airbnb:master Feb 21, 2024
2 checks passed
Copy link

github-actions bot commented Mar 4, 2024

馃帀 This PR is included in version v3.9.0 of the packages modified 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants