Avoid ResizeObserver loop limit exceeded #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice 馃檶 LGTM 馃攣 were we seeing this on dashboards? is it specific to browser versions? (I haven't seen it before, or haven't been aware of seeing it :) |
|
@williaster @michellethomas found it while working on integration test in Cypress. It crashes the test on dashboard page. |
|
published in |
shlomiassaf
added a commit
to shlomiassaf/ngrid
that referenced
this pull request
May 8, 2019
fix(ngrid): Avoid ResizeObserver loop limit exceeded See airbnb/visx#335
FezVrasta
added a commit
to FezVrasta/react-virtuoso
that referenced
this pull request
Jul 30, 2019
Copies the approach used in airbnb/visx#335 to fix a "ResizeObserver loop limit exceeded" error
FezVrasta
added a commit
to FezVrasta/react-virtuoso
that referenced
this pull request
Jul 30, 2019
Copies the approach used in airbnb/visx#335 to fix a "ResizeObserver loop limit exceeded" error
FezVrasta
added a commit
to FezVrasta/react-virtuoso
that referenced
this pull request
Jul 30, 2019
Copies the approach used in airbnb/visx#335 to fix a "ResizeObserver loop limit exceeded" error # Conflicts: # src/Utils.tsx
FezVrasta
added a commit
to FezVrasta/react-virtuoso
that referenced
this pull request
Aug 1, 2019
Copies the approach used in airbnb/visx#335 to fix a "ResizeObserver loop limit exceeded" error
FezVrasta
added a commit
to FezVrasta/react-virtuoso
that referenced
this pull request
Aug 1, 2019
Copies the approach used in airbnb/visx#335 to fix a "ResizeObserver loop limit exceeded" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Bug Fix
ResizeObserverloop limit exceeded. The issues surfaces on Chrome version >=64.Reference: WICG/resize-observer#38
Solution was to wrap the resize call in
requestAnimationFrameto avoid infinite loopReference:
cc: @michellethomas