Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript(vx-group): re-write package in TypeScript #488

Merged
merged 13 commits into from Oct 3, 2019

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Sep 11, 2019

🚀 Enhancements

This PR builds off of #484, introducing TypeScript config and converting the @vx/group package (which is quite simple) as a proof of concept. The plan is to convert packages one by one from here 📈

Notes

  • @types/* related to testing were added to the root devDeps
  • package-specific types should be added as deps in the relevant packages
  • @airbnb/config-babel adds babel-plugin-typescript-to-proptypes when used with the typescript driver, which generates PropTypes for react component types/interfaces and requires us to keep the prop-types dep though it's no longer referenced in source code. Example compiled .js file below:

Closes #510

@hshoff @milesj @schillerk @techniq

Fixes https://github.com/hshoff/vx/projects/2#card-26383081

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@williaster williaster added this to Review in progress in TypeScript Sep 12, 2019
@hshoff hshoff merged commit 19ca0d8 into chris--nimbus Oct 3, 2019
@williaster
Copy link
Collaborator Author

williaster commented Oct 4, 2019

whoops, looks like I failed to update the branch this should be merged into to master, after chris--nimbus was merged. should I open another PR for the same into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants