Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript(vx-demo): re-write in TypeScript #579

Merged
merged 153 commits into from
Jan 13, 2020
Merged

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Jan 6, 2020

📝 Documentation

This is the final major PR for the TypeScript project, and re-writes the vx-demo (private) package which powers the vx site in TypeScript as a way to verify the usability of the rest of the types. It closes #571.

I will update the following as examples are converted (I will likely do many as separate PRs into this branch for review-ability, merge them into this and this into master)

  • pack
    before/after

  • patterns
    before/after

💥 Breaking Changes

  • The @vx/mock-data Exoplanet radius and distance values were updated from strings to numbers to remove the need for consumers to coerce to numbers themselves

cc @hshoff @schillerk @kristw

Chris Williams and others added 19 commits January 12, 2020 15:21
typescript(vx-demo): rewrite Drag-i and Drag-ii demos in TypeScript
typescript(vx-demo): rewrite Legends example in TypeScript
typescript(vx-demo): rewrite Glyphs + LineRadial + Radar examples in TypeScript
@williaster williaster changed the title [WIP] typescript(vx-demo): re-write in TypeScript typescript(vx-demo): re-write in TypeScript Jan 13, 2020
@williaster
Copy link
Collaborator Author

it's done! merging to get all the fixes into the alpha release! 🎉

@williaster williaster merged commit f8e6c6d into master Jan 13, 2020
@williaster williaster deleted the chris--vx-demo-i branch January 13, 2020 19:50
@williaster williaster mentioned this pull request Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-write vx-demo in TypeScript
1 participant