Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(vx-tooltip): resolve linter errors (no-shadow) #639

Merged
merged 1 commit into from
Mar 2, 2020
Merged

style(vx-tooltip): resolve linter errors (no-shadow) #639

merged 1 commit into from
Mar 2, 2020

Conversation

ptmx
Copy link
Contributor

@ptmx ptmx commented Mar 1, 2020

🏠 Internal

@ptmx ptmx mentioned this pull request Mar 1, 2020
Merged
@ptmx ptmx changed the title fix(vx-tooltip): resolve linter errors (no-shadow) style(vx-tooltip): resolve linter errors (no-shadow) Mar 1, 2020
williaster
williaster approved these changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Hopefully can fix #638 soon so we don't repeat things like this in the future.

@williaster williaster added this to the v0.0.196 milestone Mar 2, 2020
@williaster williaster merged commit 78d9b51 into airbnb:master Mar 2, 2020
@ptmx ptmx deleted the fix/use-tooltip-lint-errors branch March 2, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏠 internal
Projects
None yet
Milestone
v0.0.196
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptmx @williaster