Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stats): update min/max in computeStats to handle no outliers #853

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

kanhegaonkarsaurabh
Copy link
Contributor

@kanhegaonkarsaurabh kanhegaonkarsaurabh commented Oct 7, 2020

🐛 Bug fix

Closes #851.

@coveralls
Copy link

coveralls commented Oct 7, 2020

Pull Request Test Coverage Report for Build 118

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 56.712%

Files with Coverage Reduction New Missed Lines %
packages/visx-responsive/src/components/ParentSize.tsx 13 0%
Totals Coverage Status
Change from base Build 292312741: -0.01%
Covered Lines: 1253
Relevant Lines: 2136

💛 - Coveralls

@williaster williaster changed the title updated min/max in computeStats to handle no outliers fix(stats): update min/max in computeStats to handle no outliers Oct 7, 2020
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @kanhegaonkarsaurabh! this looks good to me except the build is failing due to a prettier issue I commented on.

@@ -1,22 +1,28 @@
import { computeStats } from '../src';
import { computeStats } from "../src";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the addition of double quotes throughout here is failing prettier in the build. you can update them manually or run yarn format from the monorepo root.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had an issue running yarn format due to a nimbus driver not found error. Thus, I ended up doing it manually

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, should work if you run yarn in the root to install all deps. in any case glad you got it!

@kanhegaonkarsaurabh
Copy link
Contributor Author

@williaster Got it! I've updated the test file to include single quotes and fix the prettier issue

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @kanhegaonkarsaurabh 🙌 !

@williaster williaster merged commit c0eb0b2 into airbnb:master Oct 7, 2020
@williaster williaster added this to the 1.1.0 milestone Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stats/computeStats] min/max should match the dataset when there are no outliers
3 participants