Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(xychart): add BarGroup + mouseover tests #871

Merged
merged 5 commits into from
Oct 15, 2020
Merged

test(xychart): add BarGroup + mouseover tests #871

merged 5 commits into from
Oct 15, 2020

Conversation

williaster
Copy link
Collaborator

🏠 Internal

This PR

  • adds tests for BarGroup introduced in new(xychart): add BarGroup #870
  • adds __mocks__/@visx/event + setupTooltipTest helper to more easily test show/hideTooltip functionality in *Series
  • adds mouseover/mouseout tests to BarSeries, LineSeries, BarGroup, and BarStack series components

@kristw

@williaster williaster added this to Reviewable in XYChart via automation Oct 14, 2020
@williaster williaster mentioned this pull request Oct 14, 2020
Merged
2 tasks
@coveralls
Copy link

coveralls commented Oct 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 189

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.5%) to 59.899%
Totals Coverage Status
Change from base Build 186: 2.5%
Covered Lines: 1426
Relevant Lines: 2299
💛 - Coveralls

@williaster williaster force-pushed the chris--xychart-grouped-bar-tests branch from 95b6662 to 3d54674 Compare October 14, 2020 22:54
@williaster williaster force-pushed the chris--xychart-grouped-bar-tests branch from 3d54674 to 8be48e7 Compare October 15, 2020 23:24
@williaster williaster merged commit fd522db into chris--xychart-grouped-bar Oct 15, 2020
XYChart automation moved this from Reviewable to Done Oct 15, 2020
@williaster williaster deleted the chris--xychart-grouped-bar-tests branch October 15, 2020 23:25
@williaster williaster added this to the 1.1.0 milestone Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
🏠 internal @visx/xychart
Projects
XYChart
  
Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@williaster @coveralls @kristw