new(brush): expose updateBrush method #934
Conversation
| onBrushEnd={this.handleBrushEnd} | ||
| onBrushStart={this.handleBrushStart} | ||
| handleSize={handleSize} | ||
| ref={innerRef} |
There was a problem hiding this comment.
this is the added line, the rest are just sorted by proptype & name
Pull Request Test Coverage Report for Build 376396724
💛 - Coveralls |
|
@williaster if there aren't any issues with this implementation can this be added to the next release? |
There was a problem hiding this comment.
Thanks for the PR and sorry for the delayed review @peterwiebe (catching up from being out 🌴 last week). This looks great and is much simpler than my previous thinking 💯
I had a couple of minor suggestions for the demo, but then yes we should be able to get this out in the next release 👍
|
@williaster thank you for your review 🙏 I updated the PR with your feedback, please let me know if there is anything else you think could use some tweaking. |
There was a problem hiding this comment.
This looks great @peterwiebe! 💯 Thanks for the addition, I'll merge it now and try and get a release out sometime today.
|
@peterwiebe sorry for the delay, this is now out as |
|
@williaster thank you for helping me get it in 🙏 |
🚀 Enhancements
@williaster - I know you already have a PR up but I was wondering what you think of this.
cc #577