Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(xychart): add focus/blur handler tests #962

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

williaster
Copy link
Collaborator

🏠 Internal

🐛 Bug Fix

Always nice when tests reveal bugs – onFocus handlers weren't being invoked correctly in useEventHandlers, so fixed that in the process.

@hshoff @kristw

@williaster williaster added this to the 1.3.0 milestone Dec 7, 2020
@williaster williaster added this to Reviewable in XYChart via automation Dec 7, 2020
Base automatically changed from chris--xychart-focusblur to master December 8, 2020 18:52
@williaster williaster force-pushed the chris--xychart-focusblur-tests branch from 953718a to e3084c6 Compare December 8, 2020 18:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 408947118

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 61.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-xychart/src/hooks/useEventHandlers.ts 14 15 93.33%
Totals Coverage Status
Change from base Build 408941661: 0.6%
Covered Lines: 1729
Relevant Lines: 2647

💛 - Coveralls

@williaster williaster merged commit 6855925 into master Dec 8, 2020
XYChart automation moved this from Reviewable to Done Dec 8, 2020
@williaster williaster deleted the chris--xychart-focusblur-tests branch December 8, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
XYChart
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants