Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xychart/Tooltip): enable style overflow in crosshairs #997

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

williaster
Copy link
Collaborator

🐛 Bug Fix

Fixes #990. Previously setting strokeWidth on Tooltip crosshair styles had no effect because the parent SVG width/height of 1px didn't allow it. Fixed by setting overflow: visible.

Before
for vertical/horizontalCrosshairStyle={{ strokeWidth: 8, strokeDasharray: '4,4', stroke: 'yellow' }}

After
for same styles

@hshoff
cc @Janpot

@williaster williaster added this to the 1.4.0 milestone Jan 6, 2021
@williaster williaster requested a review from hshoff January 6, 2021 20:41
@williaster williaster added this to Reviewable in XYChart via automation Jan 6, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 467107801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.196%

Totals Coverage Status
Change from base Build 466988844: 0.0%
Covered Lines: 1728
Relevant Lines: 2690

💛 - Coveralls

@williaster williaster merged commit 6ce31e9 into master Jan 11, 2021
XYChart automation moved this from Reviewable to Done Jan 11, 2021
@williaster williaster deleted the chris--xychart-crosshair-styles branch January 11, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
XYChart
  
Done
Development

Successfully merging this pull request may close these issues.

[xychart] can't set strokeWidth through verticalCrosshairStyle
3 participants