-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: request is not a function #363
Comments
Well, adding the "@types/request@2.0.2" dependency in my project didn't help, I'm still getting the same error -_- |
I guess you need to install https://github.com/request/request:
|
@vmihailenco Hi, thanks for the reply ^^ I'm trying it and letting you know. |
@vmihailenco So, it works with request ^^ thanks. Mind if I send a PR with something in the README about it? (any advice on where it should go too?) |
PR is welcome - I think a note in https://github.com/airbrake/airbrake-js#setup section will be enough... |
Cool, I'm on it ^^
Le mar. 17 oct. 2017 à 11:45, Vladimir Mihailenco <notifications@github.com>
a écrit :
… PR is welcome - I think a note in
https://github.com/airbrake/airbrake-js#setup section will be enough...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAApqxPr1-RtcVZT7hPCRqlKTvWC3j_qks5stHcegaJpZM4P7zaM>
.
|
Added a note about request dependency for issue #363
I'm trying to get airbrake to work on a worker project I have (no web server, not even an api, just a simple worker that does its stuff repeatedly in its own process):
Here's what I did:
And here's what I get:
Since my keys work (tested in a ruby script) and I have followed what I found on the README, I'm guessing something might be wrong with airbrake-js itself ; my money would be on:
(because a dev dependency should not be needed in the running sources)
Since I'm a bit new to nodejs and its requirements, I'm not sure though ^^° I'd send a pull request if I was, but I'm probably going to fork and play with this just to see if I can get it to work
The text was updated successfully, but these errors were encountered: