config: enable performance_stats by default #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
performance-stats-true
branch
from
e6fb1db
to
2b5ef9f
Compare
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jul 1, 2019
With [`performance_stats = true`][1] Airbrake generates a lot of logs now. This causes some inconvenience in the development environment because Rails uses `debug` severity for its logger. We don't have a lot of places where we log but we do log frequently (on every request we log performance data for that request). Simply removing that debug output would solve the issue but we need it so we can debug the library. The best decision would be using a separate file, where we can be noisy without annoying our users. If we ever need that debug output, we can ask the users to check `airbrake.log`. [1]: airbrake/airbrake-ruby#485
kyrylo
added a commit
to airbrake/airbrake
that referenced
this pull request
Jul 1, 2019
With [`performance_stats = true`][1] Airbrake generates a lot of logs now. This causes some inconvenience in the development environment because Rails uses `debug` severity for its logger. We don't have a lot of places where we log but we do log frequently (on every request we log performance data for that request). Simply removing that debug output would solve the issue but we need it so we can debug the library. The best decision would be using a separate file, where we can be noisy without annoying our users. If we ever need that debug output, we can ask the users to check `airbrake.log`. [1]: airbrake/airbrake-ruby#485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.