Skip to content

Commit

Permalink
renaming so it's easier to understand
Browse files Browse the repository at this point in the history
  • Loading branch information
shime committed Apr 25, 2012
1 parent 99f2c1d commit 628a344
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions lib/airbrake/rails/middleware/debug_exceptions_catcher.rb
Expand Up @@ -6,7 +6,7 @@ def self.included(base)
base.send(:alias_method_chain,:render_exception,:airbrake)
end

def define_proxy_class(klass)
def define_proxy_method(klass)
klass.class_eval do
def call_the_real_method_if_exists
rescue_action_in_public_without_airbrake(request.env['fake_exception'])
Expand All @@ -19,7 +19,7 @@ def render_exception_with_airbrake(env,exception)
env['airbrake.error_id'] = Airbrake.notify_or_ignore(exception, controller.airbrake_request_data)
if defined?(controller.rescue_action_in_public_without_airbrake)
env['fake_exception'] = exception
define_proxy_class(controller.class)
define_proxy_method(controller.class)
controller.class.action(:call_the_real_method_if_exists).call(env)
else
render_exception_without_airbrake(env,exception)
Expand Down
4 changes: 2 additions & 2 deletions test/notice_test.rb
Expand Up @@ -443,10 +443,10 @@ def assert_valid_notice_document(document)
def assert_filters_hash(attribute)
filters = ["abc", :def]
original = { 'abc' => "123", 'def' => "456", 'ghi' => "789", 'nested' => { 'abc' => '100' },
'something_with_abc' => 'stop regex matching!'}
'something_with_abc' => 'match the entire string'}
filtered = { 'abc' => "[FILTERED]",
'def' => "[FILTERED]",
'something_with_abc' => "stop regex matching!",
'something_with_abc' => "match the entire string",
'ghi' => "789",
'nested' => { 'abc' => '[FILTERED]' } }

Expand Down

0 comments on commit 628a344

Please sign in to comment.