rails/app: ignore "catch-all" routes #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1091 (Performance - all routes appear as / with 10.0.3. Works fine in 9.5.5) When using Rails' `recognize`, catch-all routes have higher precedence than real routes. By skipping catch-all routes we can fall through to the next route, which appears to be a real route. One gotcha is that the API we use to check for "catch-all" routes is not available on Rails 4.1 and lower (only Rails 4.2+).
kyrylo
force-pushed
the
1091-apm-engine-routes-fix
branch
from
e7b7156
to
e4cf458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091 (Performance - all routes appear as / with 10.0.3. Works fine in
9.5.5)
When using Rails'
recognize, catch-all routes have higher precedence than realroutes. By skipping catch-all routes we can fall through to the next route,
which appears to be a real route.
One gotcha is that the API we use to check for "catch-all" routes is not
available on Rails 4.1 and lower (only Rails 4.2+).