Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemStackError:stack level too deep exceptions not being sent to Airbrake #395

Closed
joevandyk opened this issue Jun 25, 2015 · 5 comments
Closed
Labels

Comments

@joevandyk
Copy link
Contributor

I saw the following in my logs:

method=POST path=/admin/drop_shippers format=html controller=admin/drop_shippers action=create status=500 error='SystemStackError:stack level too deep' duration=21.39 db=6.68
** [Airbrake] Failure: Net::HTTPRequestEntityTooLarge

So we had a bug that resulted in an infinite loop. It looks like the exception wasn't being sent to airbrake because the stacktrace was too big. Maybe the stacktrace should be capped at a maximum limit? Or the limit should be raised to a higher amount.

@shifi
Copy link
Contributor

shifi commented Jun 26, 2015

Maximum size of notice we accept is 64kb.
The problem is that stacktrace is not the only thing which could overfill notice size.
There are other things such as params, sessions, cgi_data so it's hard to know where to reduce the size.

@joevandyk
Copy link
Contributor Author

Yeah. But maybe if the exception is one of this type, only the last, say, 30kb of the stack trace get submitted?

As is, none of these errors will make it to airbrake.

@shifi shifi added the feature label Jun 27, 2015
@shifi
Copy link
Contributor

shifi commented Jun 27, 2015

We will consider implementing this in major version. Thanks

@kyrylo
Copy link
Contributor

kyrylo commented Nov 11, 2015

This issue is fixed in the new upcoming major release. We truncate notices bigger than 64KB. The strategy to truncation is quite flexible (and non-deterministic). So, we truncate everything that can be truncated, including stack frames.

@kyrylo kyrylo closed this as completed Nov 11, 2015
@joevandyk
Copy link
Contributor Author

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants