Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log HTTP_AUTHORIZATION header by default #671

Closed
grosser opened this issue Feb 21, 2017 · 1 comment
Closed

Do not log HTTP_AUTHORIZATION header by default #671

grosser opened this issue Feb 21, 2017 · 1 comment

Comments

@grosser
Copy link
Contributor

grosser commented Feb 21, 2017

Same as 'password' afaik ... so please don't send it by default ...
@grosser grosser mentioned this issue Feb 21, 2017
Merged
grosser added a commit to zendesk/samson that referenced this issue Feb 21, 2017
@grosser
do not send tokens / passwords to airbrake
0635108 
opened airbrake/airbrake#671 to remove it by default
@grosser grosser mentioned this issue Feb 21, 2017
Merged
kyrylo added a commit that referenced this issue Feb 22, 2017
@kyrylo
generators/airbrake_initializer: ignore HTTP_AUTHORIZATION header
f6d5f1b 
Fixes #671 (Do not log HTTP_AUTHORIZATION header by default)
@kyrylo kyrylo mentioned this issue Feb 22, 2017
Merged
@kyrylo
Copy link
Contributor

kyrylo commented Feb 22, 2017

Thanks, this makes sense. Here's a PR to fix this: #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grosser @kyrylo