Add Backlog Functionality #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
kyrylo
reviewed
Sep 20, 2022
| req.Header.Set("User-Agent", userAgent) | ||
| resp, err := qb.opt.HTTPClient.Do(req) | ||
| if err != nil { | ||
| logger.Printf("Backlog queue failed = %s", err) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog queue failed = %s", err) | |
| logger.Errorf("Backlog queue failed = %s", err) |
| } | ||
| defer resp.Body.Close() | ||
| if resp.StatusCode > 400 { | ||
| logger.Printf("Backlog queue failed = %q", resp.Status) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog queue failed = %q", resp.Status) | |
| logger.Errorf("Backlog queue failed = %q", resp.Status) |
| buf, | ||
| ) | ||
| if err != nil { | ||
| logger.Printf("Backlog queue failed = %s", err) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog queue failed = %s", err) | |
| logger.Errorf("Backlog queue failed = %s", err) |
| } | ||
| defer resp.Body.Close() | ||
| if resp.StatusCode > 400 { | ||
| logger.Printf("Backlog notice failed = %q", resp.Status) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog notice failed = %q", resp.Status) | |
| logger.Errorf("Backlog notice failed = %q", resp.Status) |
| req.Header.Set("User-Agent", userAgent) | ||
| resp, err := nb.opt.HTTPClient.Do(req) | ||
| if err != nil { | ||
| logger.Printf("Backlog notice failed = %s", err) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog notice failed = %s", err) | |
| logger.Errorf("Backlog notice failed = %s", err) |
| } | ||
| defer resp.Body.Close() | ||
| if resp.StatusCode > 400 { | ||
| logger.Printf("Backlog route stat failed = %q", resp.Status) |
There was a problem hiding this comment.
Suggested change
| logger.Printf("Backlog route stat failed = %q", resp.Status) | |
| logger.Errorf("Backlog route stat failed = %q", resp.Status) |
backlog.go
Outdated
|
|
||
| // NewNoticeBacklog creates a new backlog for notices. | ||
| func NewNoticeBacklog(opt *NotifierOptions) *noticeBacklog { | ||
| if nb == nil { |
There was a problem hiding this comment.
If we use once, do we really need to wrap this in if nb == nil?
|
PTAL |
kyrylo
approved these changes
Sep 20, 2022
chimanjain
force-pushed
the
backlog-functionality
branch
from
dabbc77
to
3a8ade8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Backlog class accepts notices and APM events and synchronously sends them in
the background at regular intervals (1 minute).
The notices that it accepts are those that have failed to be sent due to network
issues or Airbrake servers struggling. If the second attempt fails, then such
data is discarded forever.
The maximum backlog size is 100.