Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better alternatives to Csv.ProcessFoo methods #15

Closed
airbreather opened this issue Jul 17, 2019 · 1 comment
Closed

Create better alternatives to Csv.ProcessFoo methods #15

airbreather opened this issue Jul 17, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@airbreather
Copy link
Owner

Csv.ProcessFoo methods don't scale very well. Every new type of input requires all the logic for scanning through the input to live in this file, and it doesn't compose very well at all.

Furthermore, all the parameters for how to process that input (e.g., buffer sizes, delimiters, ignore UTF-8 BOM or not, pooling, etc.) need to be specified as method parameters, in a particular order, on the same method call. This makes it hard to add parameters in the future.

This can all be solved by moving to an object model that serves the same purpose as the Csv class has served to-date, but with more options and an interface that's easier to extend.

@airbreather airbreather added the enhancement New feature or request label Jul 17, 2019
@airbreather airbreather added this to the 1.2.0 milestone Jul 17, 2019
@airbreather airbreather self-assigned this Jul 17, 2019
@airbreather
Copy link
Owner Author

This was done in a89f99f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant