Fix leading zeros in parser.etw.core.Guid.__str__ #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last section of the __str__ method for the Guid class, string padding to the correct hex length is not performed. If you are comparing a guid which requires zero padding, e.g. *-d312ba227f03, this method will NOT include the 0, causing it to be *-d312ba227f3 (missing zero at the end). If you want to compare string-representations of GUIDs, this code segment will cause you problems. The fix is simple, in the string-ify operation, simply force the hex character to be printed as exactly two characters, so that zero is always included
|
Thanks a lot !!! |
|
Thank you for implementing this library! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last section of the str method for the Guid class, string padding to the correct hex length is not performed.
If you are comparing a guid which requires zero padding, e.g. *-d312ba227f03, this method will NOT include the 0, causing it to be *-d312ba227f3 (missing zero at the end). If you want to compare string-representations of GUIDs, this code segment will cause you problems.
The fix is simple, in the string-ify operation, simply force the hex character to be printed as exactly two characters, so that zero is always included