Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Warnings looks like errors: Could not determine airbyte type from JSON schema #213

Open
aaronsteers opened this issue May 1, 2024 · 1 comment

Comments

@aaronsteers
Copy link
Contributor

aaronsteers commented May 1, 2024

We've received this a few times now - when PyAirbyte cannot determine a type with confidence, it prints a warning message but users often are led to believe this is fatal. We should improve the messaging here so it is more clear that this is a warning - or we should remove the messaging altogether.

Raised (most recently) here:

Background:

Whenever PyAirbyte determines a column type, it uses a heuristic to try to determine the "best" column type given the input data type. However, PyAirbyte always applies a "failsafe" data type when none can be determined otherwise. This is normally a string, JSON, or Variant column type, and in most cases the sync will succeed regardless - with no real loss of fidelity.

Example cases:

A classic example of this is a data type that is defined as anyOf(string, object). Since databases generally don't support a column type that would equally support either a string or an object (aka dictionary/struct), the cache will determine the best-available failover type, which would probably be VARCHAR - meaning object-type inputs would be converted to string. This works fine in practice; while we might lose some "data type fidelity" we generally have zero loss of "data fidelity".

Clarified messaging:

The right thing to do here (apart from adding more advanced heuristics) would be to improve messaging so that the user knows that this is not a failure condition, and that we do have a valid typing fail-safe that we are applying for this condition. Alternatively, we could eliminate this messaging entirely.

cc @marcosmarxm , @bindipankhudi

@aaronsteers aaronsteers changed the title 🐛 Bug: Warnings looks like errors 🐛 Bug: Warnings looks like errors: Could not determine airbyte type from JSON schema May 1, 2024
@gan-pit
Copy link

gan-pit commented Jun 11, 2024

same error is there for the source-stripe... will it be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants