Feat: Replace Parquet File Writer with Gzipped Jsonl File Writer #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsteers
changed the title
aaronsteers
commented
Feb 22, 2024
bindipankhudi
approved these changes
Feb 22, 2024
|
@bindipankhudi - Just FYI, there's apparently a bug in DuckDB where if you try to load a blank json file, it will just hang indefinitely. Because of this, I had to refactor the no-data treatment slightly. I modified it so that we don't actually create a batch, but we do still loop through all the streams and finalize all of them. During the finalize step, if there are no batches, then we exit after making sure the table exists. |
aaronsteers
commented
Feb 22, 2024
aaronsteers
commented
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #50
Add Jsonl file writer.
This file writer better supports variable schemas that were breaking the Parquet writer.