Skip to content

Commit

Permalink
Add loadBalancerIP to service spec in APIs charts
Browse files Browse the repository at this point in the history
  • Loading branch information
pdemagny committed Mar 13, 2024
1 parent 6cf30cb commit f236e73
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
3 changes: 3 additions & 0 deletions charts/airbyte-api-server/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ metadata:
{{- include "airbyte.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{- end }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
Expand Down
4 changes: 1 addition & 3 deletions charts/airbyte-api-server/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

global:
serviceAccountName: placeholderServiceAccount
deploymentMode: oss
Expand Down Expand Up @@ -136,6 +135,7 @@ resources:
## service.port The service port to expose the API server on
service:
type: ClusterIP
loadBalancerIP: ""
port: 8006
annotations: {}

Expand Down Expand Up @@ -255,13 +255,11 @@ secrets: {}
# CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: 0.35.15.001
env_vars: {}


## extraSelectorLabels [object] - use to specify own additional selector labels for deployment
extraSelectorLabels: {}
## extraLabels [object] - use to specify own additional labels for deployment
extraLabels: {}


## deploymentStrategyType [string] - deployment strategy type for airbyte-server deployment.
## Defaults to Recreate since the pod is using pvc
deploymentStrategyType: Recreate
Expand Down
3 changes: 3 additions & 0 deletions charts/airbyte-server/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ metadata:
{{- include "airbyte.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.service.loadBalancerIP }}
{{- end }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
Expand Down
4 changes: 1 addition & 3 deletions charts/airbyte-server/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

global:
serviceAccountName: placeholderServiceAccount
deploymentMode: oss
Expand Down Expand Up @@ -97,6 +96,7 @@ resources:
## service.port The service port to expose the API server on
service:
type: ClusterIP
loadBalancerIP: ""
port: 8001
annotations: {}

Expand Down Expand Up @@ -192,13 +192,11 @@ secrets: {}
# CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: 0.35.15.001
env_vars: {}


## extraSelectorLabels [object] - use to specify own additional selector labels for deployment
extraSelectorLabels: {}
## extraLabels [object] - use to specify own additional labels for deployment
extraLabels: {}


## deploymentStrategyType [string] - deployment strategy type for airbyte-server deployment.
## Defaults to Recreate since the pod is using pvc
deploymentStrategyType: Recreate
Expand Down

0 comments on commit f236e73

Please sign in to comment.