New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stream status trace message #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me on the changes to protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
But I don't know what is supposed to happen with the V1 file
Something is up with the python files too:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not familiar with the other process pieces to publish this so can't comment there.
@evantahler @gosusnp @davinchia After speaking with @cgardens, I have updated this change to also include an optional stream descriptor in the I am also not sure what the next step is to get this merged and released, once approved. There appears to be some issues with the CI build and I am not that familiar with this module to know if this is just noise or will also fail on merge. |
@evantahler As far as I can tell, this error is happening before it even attempts to do the code generation. It's some failure attempting to install the |
@evantahler Disregard. I figured it out. We don't have the |
Adds a new trace message used to convey stream status.
I am not sure about how to ensure that this ends up in the correct protocol version, now that this has been broken out into its own repo. Please advise on any changes needed to tie this change to the correct protocol version.