Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove success in favor of explicit status enum values #34

Merged
merged 1 commit into from Apr 20, 2023
Merged

fix: Remove success in favor of explicit status enum values #34

merged 1 commit into from Apr 20, 2023

Conversation

jdpgrailsdev
Copy link
Contributor

Removes the success optional field from the AirbyteStreamStatusTraceMessage in favor of explicit values in the AirbyteStreamStatus enumeration.

davinchia
davinchia approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right!

cgardens
cgardens approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. matches what we discussed in slack.

@jdpgrailsdev jdpgrailsdev merged commit 046c4e2 into main Apr 20, 2023
7 checks passed
@jdpgrailsdev jdpgrailsdev deleted the jonathan/update-status-enum branch April 20, 2023 23:14
@github-actions github-actions bot mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

@davinchia davinchia davinchia approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

@tryangul tryangul Awaiting requested review from tryangul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdpgrailsdev @cgardens @davinchia