Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove authSpecification from Airbyte protocol #39

Merged
merged 1 commit into from Jul 31, 2023

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Jun 2, 2023

What

Relates to airbytehq/airbyte#15019

Protocol Change Proposal doc

Removes authSpecification from the Airbyte protocol, as it has been replaced by advancedAuth.

This should only be merged once all connectors in the Airbyte catalog have been migrated to advancedAuth and all references to authSpecification have been removed from the Airbyte platform. See the epic for the status of the connector migrations.
EDIT: All connectors have now been migrated off of authSpecification, and all references have been removed from the Airbyte platform, so this should now be safe to merge.

Note for users

Airbyte users and custom connector authors shouldn't need to worry about this change, since authSpecification is an internal-only field that requires changes to the Airbyte platform to function, so it should not be used by custom connectors or community members.

The main consequence that users may see is if they upgrade their Airbyte platform to a version in which authSpecification is removed, but they are using an old version of a connector that still utilizes authSpecification, then they may see an error message in the Airbyte UI when trying to open the connector settings, which will direct them to upgrade to the latest connector version to resolve the issue.

@lmossman lmossman changed the title Remove authSpecification from Airbyte protocol feat: Remove authSpecification from Airbyte protocol Jun 2, 2023
@lmossman lmossman changed the title feat: Remove authSpecification from Airbyte protocol refactor: Remove authSpecification from Airbyte protocol Jun 2, 2023
@lmossman lmossman requested a review from sherifnada July 31, 2023 22:20
@lmossman lmossman marked this pull request as ready for review July 31, 2023 22:21
@lmossman lmossman merged commit 029148b into main Jul 31, 2023
15 of 16 checks passed
@lmossman lmossman deleted the lmossman/remove-auth-specification branch July 31, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants