fix: only add user selected streams to the catalog diff #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutra-osmani
changed the title
flutra-osmani
changed the title
flutra-osmani
changed the title
benmoriceau
approved these changes
Dec 7, 2023
flutra-osmani
deleted the
flutra/23361-remove-update-for-inactive-streams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
getCatalogDiffcompares the existing source catalog with the newly discovered one and if there's a difference, it includes the corresponding stream in the update that shows up in the UI. However, a given stream may not be toggled (selected) by the customer, thus it should not be included in the update. This change ensures that, in addition to doing a comparison between the new and old catalog, the configured catalog must also be present. Inactive streams will not show up in the ConfiguredCatalog.Solves airbytehq/airbyte#23361