Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed unused V1. #58

Merged
merged 1 commit into from Dec 26, 2023
Merged

fix: Removed unused V1. #58

merged 1 commit into from Dec 26, 2023

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Dec 22, 2023

We do not use V1. Instead of duplicate, potential drift and confusion, let's remove V1 for now and re-introduce when we are ready to move to V1.

@davinchia davinchia changed the title Remove V1: We do not use this. Fix: Removed unused V1. Dec 22, 2023
@davinchia davinchia changed the title Fix: Removed unused V1. fix: Removed unused V1. Dec 22, 2023
@evantahler
Copy link
Contributor

I'm more confused about the difference between "v0" and the root item, which are different files and not symlinks - what's up with that?

@davinchia
Copy link
Contributor Author

Me too! I had to check with @gosusnp and @jdpgrailsdev to clarify:

  • this is leftover from when we tried to go to V1. We ended up backing out because the work was too involved.
  • in the original proposal, the root file was supposed to be a symlink to the protocol file in v0, so we only updated one place even after the back out.
  • it looks like we lost that in the move to this repo. Looking at the platform repo, it looks like we use both packages, which means we need to update both files..
  • I'm going to open a follow up conversation in our channel to clear some of this up. I think we should handle resolving this in a separate PR.

@davinchia davinchia merged commit 24be395 into main Dec 26, 2023
8 of 10 checks passed
@davinchia davinchia deleted the davinchia/remove-v1-folder branch December 26, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants