Skip to content

Commit

Permalink
use longer short shas (#19190)
Browse files Browse the repository at this point in the history
it seems github APIs want us to use longer shas in some cases where a
7 character short sha is still entirely valid

So just set the minimum short sha length to 10
  • Loading branch information
git-phu committed Nov 9, 2022
1 parent 17e869f commit 013ecf7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build-branch/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
# if the *branch_version_tag* input param is not specified, then generate it as 'dev-<commit_hash>`
#
[[ "${{ inputs.branch_version_tag }}" != '' ]] && echo "branch_version_tag=${{ inputs.branch_version_tag }}" >> $GITHUB_OUTPUT \
|| { short_hash=$(git rev-parse --short=7 HEAD); echo "branch_version_tag=dev-$short_hash" >> $GITHUB_OUTPUT ; }
|| { short_hash=$(git rev-parse --short=10 HEAD); echo "branch_version_tag=dev-$short_hash" >> $GITHUB_OUTPUT ; }
- uses: actions/setup-java@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-oss-for-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
run: |-
set -x
commit_sha=$(git rev-parse --short=7 HEAD)
commit_sha=$(git rev-parse --short=10 HEAD)
# set dev_tag
# AirbyteVersion.java allows versions that have a prefix of 'dev'
Expand Down

0 comments on commit 013ecf7

Please sign in to comment.