🎉 Source Amazon Ads: increase report_wait_timeout 30 -> 60 minutes (#…

…16453) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
airbytehq · Sep 10, 2022 · 0ab777f · 0ab777f
1 parent c19811f
commit 0ab777f
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 19 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -25,7 +25,7 @@
 - name: Amazon Ads
   sourceDefinitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
   dockerRepository: airbyte/source-amazon-ads
-  dockerImageTag: 0.1.19
+  dockerImageTag: 0.1.20
   documentationUrl: https://docs.airbyte.io/integrations/sources/amazon-ads
   icon: amazonads.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -492,7 +492,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-amazon-ads:0.1.19"
+- dockerImage: "airbyte/source-amazon-ads:0.1.20"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/amazon-ads"
     connectionSpecification:
@@ -539,10 +539,10 @@
           order: 4
         report_wait_timeout:
           title: "Report Wait Timeout *"
-          description: "Timeout duration in minutes for Reports. Default is 30 minutes."
-          default: 30
+          description: "Timeout duration in minutes for Reports. Default is 60 minutes."
+          default: 60
           examples:
-          - 30
+          - 60
           - 120
           order: 5
           type: "integer"

diff --git a/airbyte-integrations/connectors/source-amazon-ads/Dockerfile b/airbyte-integrations/connectors/source-amazon-ads/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.19
+LABEL io.airbyte.version=0.1.20
 LABEL io.airbyte.name=airbyte/source-amazon-ads
diff --git a/airbyte-integrations/connectors/source-amazon-ads/integration_tests/spec.json b/airbyte-integrations/connectors/source-amazon-ads/integration_tests/spec.json
@@ -40,9 +40,9 @@
       },
       "report_wait_timeout": {
         "title": "Report Wait Timeout *",
-        "description": "Timeout duration in minutes for Reports. Default is 30 minutes.",
-        "default": 30,
-        "examples": [30, 120],
+        "description": "Timeout duration in minutes for Reports. Default is 60 minutes.",
+        "default": 60,
+        "examples": [60, 120],
         "order": 5,
         "type": "integer"
       },

diff --git a/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/spec.yaml b/airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/spec.yaml
@@ -48,10 +48,10 @@ connectionSpecification:
       order: 4
     report_wait_timeout:
       title: Report Wait Timeout *
-      description: Timeout duration in minutes for Reports. Default is 30 minutes.
-      default: 30
+      description: Timeout duration in minutes for Reports. Default is 60 minutes.
+      default: 60
       examples:
-        - 30
+        - 60
         - 120
       order: 5
       type: integer

diff --git a/...s/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/report_streams.py b/...s/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/report_streams.py
@@ -103,7 +103,7 @@ def __init__(self, config: Mapping[str, Any], profiles: List[Profile], authentic
         self._authenticator = authenticator
         self._session = requests.Session()
         self._model = self._generate_model()
-        self.report_wait_timeout = config.get("report_wait_timeout", 30)
+        self.report_wait_timeout = config.get("report_wait_timeout", 60)
         self.report_generation_maximum_retries = config.get("report_generation_max_retries", 5)
         self._start_date: Optional[Date] = config.get("start_date")
         super().__init__(config, profiles)

diff --git a/airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py b/airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py
@@ -241,7 +241,7 @@ def test_display_report_stream_init_too_many_requests(mocker, config):
         ),
         (
             [
-                (lambda x: x > 5, None, "2021-01-02 03:34:05"),
+                (lambda x: x > 5, None, "2021-01-02 04:04:05"),
             ],
             ReportGenerationInProgress,
         ),
@@ -256,11 +256,11 @@ def test_display_report_stream_init_too_many_requests(mocker, config):
         (
             [
                 (lambda x: True, "FAILURE", None),
-                (lambda x: x >= 10, None, "2021-01-02 03:34:05"),
-                (lambda x: x >= 15, None, "2021-01-02 04:04:05"),
-                (lambda x: x >= 20, None, "2021-01-02 04:34:05"),
-                (lambda x: x >= 25, None, "2021-01-02 05:04:05"),
-                (lambda x: x >= 30, None, "2021-01-02 05:34:05"),
+                (lambda x: x >= 10, None, "2021-01-02 04:04:05"),
+                (lambda x: x >= 15, None, "2021-01-02 05:04:05"),
+                (lambda x: x >= 20, None, "2021-01-02 06:04:05"),
+                (lambda x: x >= 25, None, "2021-01-02 07:04:05"),
+                (lambda x: x >= 30, None, "2021-01-02 08:04:05"),
             ],
             ReportGenerationFailure,
         ),

diff --git a/docs/integrations/sources/amazon-ads.md b/docs/integrations/sources/amazon-ads.md
@@ -90,6 +90,7 @@ Information about expected report generation waiting time you may find [here](ht
 
 | Version | Date       | Pull Request                                               | Subject                                                                                                           |
 |:--------|:-----------|:-----------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------|
+| 0.1.20 | 2022-09-08 | [16453](https://github.com/airbytehq/airbyte/pull/16453)    | Increase `report_wait_timeout` 30 -> 60 minutes                                                                   |
 | 0.1.19 | 2022-08-31 | [16191](https://github.com/airbytehq/airbyte/pull/16191)    | Improved connector's input configuration validation                                                               |
 | 0.1.18 | 2022-08-25 | [15951](https://github.com/airbytehq/airbyte/pull/15951)    | Skip API error "Tactic T00020 is not supported for report API in marketplace A1C3SOZRARQ6R3."                     |
 | 0.1.17 | 2022-08-24 | [15921](https://github.com/airbytehq/airbyte/pull/15921)    | Skip API error "Report date is too far in the past."                                                              |