Skip to content

Commit

Permalink
🐛 Source Bing Ads: fix missing fields (#30791)
Browse files Browse the repository at this point in the history
  • Loading branch information
@davydov-d
davydov-d committed Sep 28, 2023
1 parent 61a63ec commit 0d39e09
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/Dockerfile
View file
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.1
LABEL io.airbyte.version=0.2.2
LABEL io.airbyte.name=airbyte/source-bing-ads
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml
View file
Expand Up @@ -34,10 +34,12 @@ acceptance_tests:
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: geographic_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
timeout_seconds: 900
full_refresh:
tests:
- config_path: secrets/config.json
configured_catalog_path: integration_tests/configured_catalog.json
timeout_seconds: 900
incremental:
tests:
bypass_reason: "SAT doesn't support complex nested states used in incremental report streams"
10 changes: 0 additions & 10 deletions airbyte-integrations/connectors/source-bing-ads/integration_tests/configured_catalog.json
View file
Expand Up @@ -156,16 +156,6 @@
"cursor_field": ["TimePeriod"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "geographic_performance_report_daily",
"json_schema": {},
"supported_sync_modes": ["incremental", "full_refresh"]
},
"sync_mode": "incremental",
"cursor_field": ["TimePeriod"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "geographic_performance_report_weekly",
Expand Down
6 changes: 3 additions & 3 deletions airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.txt
View file
Expand Up @@ -18,6 +18,6 @@
{"stream": "keyword_performance_report_daily", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "KeywordId": 84525593559629, "AdId": 84525295496190, "TimePeriod": "2021-08-03", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Smartphone", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Android", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "AccountName": "Daxtarity Inc.", "CampaignName": "Test 2", "AdGroupName": "Airbyte", "Keyword": "data integration tools", "KeywordStatus": "Active", "Impressions": 1, "Clicks": 0, "Ctr": 0.0, "CurrentMaxCpc": 0.11, "Spend": 0.0, "CostPerConversion": null, "QualityScore": 0.0, "ExpectedCtr": "--", "AdRelevance": 0.0, "LandingPageExperience": 0.0, "QualityImpact": 0.0, "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "CustomParameters": null, "FinalAppUrl": null, "Mainline1Bid": null, "MainlineBid": null, "FirstPageBid": null, "FinalUrlSuffix": null, "ViewThroughConversions": 0, "ViewThroughConversionsQualified": null, "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null, "HistoricalQualityScore": 8.0, "HistoricalExpectedCtr": 2.0, "HistoricalAdRelevance": 3.0, "HistoricalLandingPageExperience": 3.0}, "emitted_at": 1679951505600}
{"stream": "keyword_performance_report_weekly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "KeywordId": 84525593559629, "AdId": 84525295496190, "TimePeriod": "2021-08-01", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Tablet", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Android", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "AccountName": "Daxtarity Inc.", "CampaignName": "Test 2", "AdGroupName": "Airbyte", "Keyword": "data integration tools", "KeywordStatus": "Active", "Impressions": 1, "Clicks": 0, "Ctr": 0.0, "CurrentMaxCpc": 0.11, "Spend": 0.0, "CostPerConversion": null, "QualityScore": 0.0, "ExpectedCtr": "--", "AdRelevance": 0.0, "LandingPageExperience": 0.0, "QualityImpact": 0.0, "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "CustomParameters": null, "FinalAppUrl": null, "Mainline1Bid": null, "MainlineBid": null, "FirstPageBid": null, "FinalUrlSuffix": null, "ViewThroughConversions": 0, "ViewThroughConversionsQualified": null, "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1679951543951}
{"stream": "keyword_performance_report_monthly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "KeywordId": 84525593559629, "AdId": 84525295496190, "TimePeriod": "2021-08-01", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Tablet", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Android", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "AccountName": "Daxtarity Inc.", "CampaignName": "Test 2", "AdGroupName": "Airbyte", "Keyword": "data integration tools", "KeywordStatus": "Active", "Impressions": 1, "Clicks": 0, "Ctr": 0.0, "CurrentMaxCpc": 0.11, "Spend": 0.0, "CostPerConversion": null, "QualityScore": 0.0, "ExpectedCtr": "--", "AdRelevance": 0.0, "LandingPageExperience": 0.0, "QualityImpact": 0.0, "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "CustomParameters": null, "FinalAppUrl": null, "Mainline1Bid": null, "MainlineBid": null, "FirstPageBid": null, "FinalUrlSuffix": null, "ViewThroughConversions": 0, "ViewThroughConversionsQualified": null, "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1679951588461}
{"stream": "geographic_performance_report_daily", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-09", "Country": "Australia", "State": "New South Wales", "MetroArea": null, "City": null, "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Windows", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "2000", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": "2000", "LocationId": "122395", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "100.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1692275353788}
{"stream": "geographic_performance_report_weekly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-06", "Country": "Australia", "State": null, "MetroArea": null, "City": null, "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Unknown", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "Australia", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": null, "LocationId": "9", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "100.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1692275162937}
{"stream": "geographic_performance_report_monthly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-01", "Country": "United Arab Emirates", "State": null, "MetroArea": null, "City": null, "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Bing and Yahoo! search", "DeviceOS": "Windows", "TopVsOther": "Bing and Yahoo! search - Top", "BidMatchType": "Broad", "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "United Arab Emirates", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": null, "LocationId": "218", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "100.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1692275633242}
{"stream": "geographic_performance_report_daily", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-09", "Country": "Australia", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Syndicated search partners", "DeviceOS": "Windows", "TopVsOther": "Syndicated search partners - Top", "BidMatchType": "Broad", "MetroArea": null, "State": "New South Wales", "City": null, "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "2000", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": "2000", "LocationId": "122395", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "100.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Clicks": 0, "Spend": 0.0, "Impressions": 1, "CostPerConversion": null, "AccountName": "Daxtarity Inc.", "AccountNumber": "F149GKV5", "CampaignName": "Test 2", "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1695825623738}
{"stream": "geographic_performance_report_weekly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-06", "Country": "Australia", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Bing and Yahoo! search", "DeviceOS": "Windows", "TopVsOther": "Bing and Yahoo! search - Other", "BidMatchType": "Broad", "MetroArea": null, "State": "New South Wales", "City": null, "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "New South Wales", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": null, "LocationId": "4048", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "0.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Clicks": 0, "Spend": 0.0, "Impressions": 1, "CostPerConversion": null, "AccountName": "Daxtarity Inc.", "AccountNumber": "F149GKV5", "CampaignName": "Test 2", "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1695825558741}
{"stream": "geographic_performance_report_monthly", "data": {"AccountId": 180278106, "CampaignId": 413444833, "AdGroupId": 1352400325389092, "TimePeriod": "2021-06-01", "Country": "United Arab Emirates", "CurrencyCode": "USD", "DeliveredMatchType": "Broad", "AdDistribution": "Search", "DeviceType": "Computer", "Language": "English", "Network": "Bing and Yahoo! search", "DeviceOS": "Windows", "TopVsOther": "Bing and Yahoo! search - Top", "BidMatchType": "Broad", "MetroArea": null, "State": null, "City": null, "AdGroupName": "Airbyte", "Ctr": 0.0, "ProximityTargetLocation": null, "Radius": "0", "Assists": 0, "ReturnOnAdSpend": null, "CostPerAssist": null, "LocationType": "Physical location", "MostSpecificLocation": "United Arab Emirates", "AccountStatus": "Active", "CampaignStatus": "Paused", "AdGroupStatus": "Active", "County": null, "PostalCode": null, "LocationId": "218", "BaseCampaignId": "413444833", "AllCostPerConversion": null, "AllReturnOnAdSpend": null, "ViewThroughConversions": 0, "Goal": null, "GoalType": null, "AbsoluteTopImpressionRatePercent": 0.0, "TopImpressionRatePercent": "100.00%", "AllConversionsQualified": "0.00", "ViewThroughConversionsQualified": null, "Neighborhood": null, "ViewThroughRevenue": "0.00", "CampaignType": "Search & content", "AssetGroupId": null, "AssetGroupName": null, "AssetGroupStatus": null, "Clicks": 0, "Spend": 0.0, "Impressions": 1, "CostPerConversion": null, "AccountName": "Daxtarity Inc.", "AccountNumber": "F149GKV5", "CampaignName": "Test 2", "Conversions": 0.0, "ConversionRate": null, "ConversionsQualified": 0.0, "AverageCpc": 0.0, "AveragePosition": 0.0, "AverageCpm": 0.0, "AllConversions": 0, "AllConversionRate": null, "AllRevenue": 0.0, "AllRevenuePerConversion": null, "Revenue": 0.0, "RevenuePerConversion": null, "RevenuePerAssist": null}, "emitted_at": 1695825503003}
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/metadata.yaml
View file
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 0.2.1
dockerImageTag: 0.2.2
dockerRepository: airbyte/source-bing-ads
githubIssueLabel: source-bing-ads
icon: bingads.svg
Expand Down
7 changes: 7 additions & 0 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/source.py
View file
Expand Up @@ -751,6 +751,13 @@ class GeographicPerformanceReport(PerformanceReportsMixin, BingAdsStream):
"AssetGroupId",
"AssetGroupName",
"AssetGroupStatus",
"Clicks",
"Spend",
"Impressions",
"CostPerConversion",
"AccountName",
"AccountNumber",
"CampaignName",
*CONVERSION_FIELDS,
*AVERAGE_FIELDS,
*ALL_CONVERSION_FIELDS,
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/bing-ads.md
View file
Expand Up @@ -123,6 +123,7 @@ The Bing Ads API limits the number of requests for all Microsoft Advertising cli

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------|
| 0.2.2 | 2023-09-27 | [30791](https://github.com/airbytehq/airbyte/pull/30791) | Fix missing fields for geographic performance reports. |
| 0.2.1 | 2023-09-04 | [30128](https://github.com/airbytehq/airbyte/pull/30128) | Add increasing download timeout if ReportingDownloadException occurs |
| 0.2.0 | 2023-08-17 | [27619](https://github.com/airbytehq/airbyte/pull/27619) | Add Geographic Performance Report |
| 0.1.24 | 2023-06-22 | [27619](https://github.com/airbytehq/airbyte/pull/27619) | Retry request after facing temporary name resolution error. |
Expand Down

0 comments on commit 0d39e09

Please sign in to comment.