allow s3 config to have http string

airbytehq · Nov 7, 2023 · 0d52e98 · 0d52e98
1 parent e030e33
commit 0d52e98
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/airbyte-ci/connectors/connector_ops/connector_ops/qa_checks.py b/airbyte-ci/connectors/connector_ops/connector_ops/qa_checks.py
@@ -170,6 +170,10 @@ def read_all_files_in_directory(
     ".hypothesis",
 }
 
+IGNORED_FILES_FOR_HTTPS_CHECKS = {
+    "airbyte-integrations/connectors/source-s3/source_s3/v4/config.py",  # This file has regex pattern using http:// .
+}
+
 IGNORED_FILENAME_PATTERN_FOR_HTTPS_CHECKS = {"*Test.java", "*.jar", "*.pyc", "*.gz", "*.svg"}
 IGNORED_URLS_PREFIX = {
     "http://json-schema.org",
@@ -207,6 +211,8 @@ def check_connector_https_url_only(connector: Connector) -> bool:
     for filename, line in read_all_files_in_directory(
         connector.code_directory, IGNORED_DIRECTORIES_FOR_HTTPS_CHECKS, IGNORED_FILENAME_PATTERN_FOR_HTTPS_CHECKS
     ):
+        if str(filename) in IGNORED_FILES_FOR_HTTPS_CHECKS:
+            continue
         line = line.lower()
         if is_comment(line, filename):
             continue

diff --git a/airbyte-ci/connectors/connector_ops/pyproject.toml b/airbyte-ci/connectors/connector_ops/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "connector_ops"
-version = "0.3.1"
+version = "0.3.2"
 description = "Packaged maintained by the connector operations team to perform CI for connectors"
 authors = ["Airbyte <contact@airbyte.io>"]