Skip to content

Commit

Permalink
Fix broken links in (#5059)
Browse files Browse the repository at this point in the history
Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>
  • Loading branch information
avaidyanatha and Abhi Vaidyanatha committed Jul 28, 2021
1 parent 3765bcf commit 211383d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions docs/connector-development/README.md
Expand Up @@ -21,7 +21,7 @@ Before building a new connector, review [Airbyte's data protocol specification](
To add a new connector you need to:

1. Implement & Package your connector in an Airbyte Protocol compliant Docker image
2. Add integration tests for your connector. At a minimum, all connectors must pass [Airbyte's standard test suite](testing-connectors/testing-connectors.md), but you can also add your own tests.
2. Add integration tests for your connector. At a minimum, all connectors must pass [Airbyte's standard test suite](testing-connectors/README.md), but you can also add your own tests.
3. Document how to build & test your connector
4. Publish the Docker image containing the connector

Expand Down Expand Up @@ -63,7 +63,7 @@ As you implement your connector, make sure to review the [Best Practices for Con

### 2. Integration tests

At a minimum, your connector must implement the acceptance tests described in [Testing Connectors](testing-connectors/testing-connectors.md)
At a minimum, your connector must implement the acceptance tests described in [Testing Connectors](testing-connectors/README.md)

**Note: Acceptance tests are not yet available for Python destination connectors. Coming [soon](https://github.com/airbytehq/airbyte/issues/4698)!**

Expand Down
2 changes: 1 addition & 1 deletion docs/connector-development/best-practices.md
Expand Up @@ -31,7 +31,7 @@ When reviewing connectors, we'll use the following "checklist" to verify whether
* **API connectors** should validate records that every stream outputs data
* If this causes rate limiting problems, there should be a periodic CI build which tests this on a less frequent cadence to avoid rate limiting

**Thoroughly test edge cases.** While Airbyte provides a [Standard Test Suite](testing-connectors/testing-connectors.md#airbytes-standard-tests) that all connectors must pass, it's not possible for the standard test suite to cover all edge cases. When in doubt about whether the standard tests provide sufficient evidence of functionality, write a custom test case for your connector.
**Thoroughly test edge cases.** While Airbyte provides a [Standard Test Suite](testing-connectors/source-acceptance-tests-reference.md) that all connectors must pass, it's not possible for the standard test suite to cover all edge cases. When in doubt about whether the standard tests provide sufficient evidence of functionality, write a custom test case for your connector.

### Check Connection

Expand Down
Expand Up @@ -34,7 +34,7 @@ A Slice object is not typed, and the developer is free to include any informatio

As an example, suppose an API is able to dispense data hourly. If the last sync was exactly 24 hours ago, we can either make an API call retrieving all data at once, or make 24 calls each retrieving an hour's worth of data. In the latter case, the `stream_slices` function, sees that the previous state contains yesterday's timestamp, and returns a list of 24 Slices, each with a different hourly timestamp to be used when creating request. If the stream fails halfway through \(at the 12th slice\), then the next time it starts reading, it will read from the beginning of the 12th slice.

For a more in-depth description of stream slicing, see the [Stream Slices guide](stream_slices.md).
For a more in-depth description of stream slicing, see the [Stream Slices guide](stream-slices.md).

## Conclusion

Expand Down
Expand Up @@ -2,8 +2,8 @@

## Airbyte's Standard Tests (v1)

This document describes the old version Standard Tests, please check the latest version [here](../../connector-development/testing-connectors/testing-connectors.md)
To ensure a minimum quality bar, Airbyte runs all connectors against the same set of integration tests \(sources & destinations have two different test suites\). Those tests ensure that each connector adheres to the [Airbyte Specification](../../architecture/airbyte-specification.md) and responds correctly to Airbyte commands when provided valid \(or invalid\) inputs.
This document describes the old version Standard Tests, please check the latest version [here](../../connector-development/testing-connectors/README.md)
To ensure a minimum quality bar, Airbyte runs all connectors against the same set of integration tests \(sources & destinations have two different test suites\). Those tests ensure that each connector adheres to the [Airbyte Specification](../../understanding-airbyte/airbyte-specification.md) and responds correctly to Airbyte commands when provided valid \(or invalid\) inputs.

### Architecture of standard tests

Expand Down Expand Up @@ -41,7 +41,7 @@ airbyteStandardSourceTestFile {
}
```

These inputs are all described in the [Airbyte Specification](../../architecture/airbyte-specification.md) and will be used as follows:
These inputs are all described in the [Airbyte Specification](../../understanding-airbyte/airbyte-specification.md) and will be used as follows:

* **Spec file** will be compared to the spec file output by the connector when the `spec` command is called.
* **Config file** is expected to be a valid config file. It's expected that calling `check` with this config will succeed.
Expand Down

0 comments on commit 211383d

Please sign in to comment.