-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
馃悰 Source Retently: Fix invalid json schema for
nps stream (#25714)
* [FIX] fix nps json schema Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * [UPD] bump version to v0.1.4 Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * [UPD] add PR to changelog Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * [UPD] update acceptance test config to new version Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * [UPD] schemas Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * add nulls to feedback schema, bump dockerfile, metadata.yaml and readme * remove unused parse function * [FIX] json schemas Signed-off-by: Henri Blancke <blanckehenri@gmail.com> * fix broken schema files * enable backwards_compatibility for 0.1.5 * add back date-time to outbox.json schema and cast empty strings to null * refactor: improve handling of empty strings Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> --------- Signed-off-by: Henri Blancke <blanckehenri@gmail.com> Co-authored-by: sajarin <sajarindider@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
- Loading branch information
3 people
committed
May 19, 2023
1 parent
1c853a7
commit 381f49e
Showing
13 changed files
with
324 additions
and
166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 26 additions & 16 deletions
42
airbyte-integrations/connectors/source-retently/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,32 @@ | ||
| # See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) | ||
| # for more information about how to configure these tests | ||
| connector_image: airbyte/source-retently:dev | ||
| tests: | ||
| acceptance_tests: | ||
| spec: | ||
| - spec_path: "source_retently/spec.json" | ||
| tests: | ||
| - spec_path: "source_retently/spec.json" | ||
| connection: | ||
| - config_path: "secrets/config.json" | ||
| status: "succeed" | ||
| - config_path: "secrets/old_config.json" | ||
| status: "succeed" | ||
| - config_path: "secrets/config_oauth.json" | ||
| status: "succeed" | ||
| - config_path: "integration_tests/invalid_config.json" | ||
| status: "failed" | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| status: "succeed" | ||
| - config_path: "secrets/old_config.json" | ||
| status: "succeed" | ||
| - config_path: "secrets/config_oauth.json" | ||
| status: "succeed" | ||
| - config_path: "integration_tests/invalid_config.json" | ||
| status: "failed" | ||
| discovery: | ||
| - config_path: "secrets/config.json" | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| backward_compatibility_tests_config: | ||
| disable_for_version: "0.1.5" | ||
| basic_read: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| empty_streams: ["reports"] | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| empty_streams: | ||
| - name: reports | ||
| full_refresh: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| tests: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 34 additions & 11 deletions
45
airbyte-integrations/connectors/source-retently/source_retently/schemas/companies.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,47 @@ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { "type": "string" }, | ||
| "createdDate": { "type": "string" }, | ||
| "domain": { "type": "string" }, | ||
| "companyName": { "type": "string" }, | ||
| "industryName": { "type": "string" }, | ||
| "id": { | ||
| "type": "string" | ||
| }, | ||
| "createdDate": { | ||
| "type": ["string", "null"], | ||
| "format": "date-time" | ||
| }, | ||
| "domain": { | ||
| "type": ["string", "null"] | ||
| }, | ||
| "companyName": { | ||
| "type": ["string", "null"] | ||
| }, | ||
| "industryName": { | ||
| "type": ["string", "null"] | ||
| }, | ||
| "tags": { | ||
| "type": "array", | ||
| "items": { "type": "string" } | ||
| "items": { | ||
| "type": ["string", "null"] | ||
| } | ||
| }, | ||
| "cxMetrics": { | ||
| "type": "object", | ||
| "properties": { | ||
| "NPS": { "type": ["number", "null"] }, | ||
| "CSAT": { "type": ["number", "null"] }, | ||
| "CES": { "type": ["number", "null"] }, | ||
| "STAR": { "type": ["number", "null"] } | ||
| "NPS": { | ||
| "type": ["number", "null"] | ||
| }, | ||
| "CSAT": { | ||
| "type": ["number", "null"] | ||
| }, | ||
| "CES": { | ||
| "type": ["number", "null"] | ||
| }, | ||
| "STAR": { | ||
| "type": ["number", "null"] | ||
| } | ||
| } | ||
| }, | ||
| "contactsCount": { "type": "number" } | ||
| "contactsCount": { | ||
| "type": ["number", "null"] | ||
| } | ||
| } | ||
| } |
51 changes: 39 additions & 12 deletions
51
airbyte-integrations/connectors/source-retently/source_retently/schemas/customers.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 30 additions & 12 deletions
42
airbyte-integrations/connectors/source-retently/source_retently/schemas/nps.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,35 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "additionalProperties": true, | ||
| "properties": { | ||
| "score": { "type": "integer" }, | ||
| "scoreSum": { "type": "integer" }, | ||
| "metricsType": { "type": "string" }, | ||
| "promoters": { "type": "integer" }, | ||
| "passives": { "type": "integer" }, | ||
| "detractors": { "type": "integer" }, | ||
| "promotersCount": { "type": "integer" }, | ||
| "passivesCount": { "type": "integer" }, | ||
| "detractorsCount": { "type": "integer" }, | ||
| "totalResponses": { "type": "integer" } | ||
| "score": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "scoreSum": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "metricsType": { | ||
| "type": ["string", "null"] | ||
| }, | ||
| "promoters": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "passives": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "detractors": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "promotersCount": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "passivesCount": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "detractorsCount": { | ||
| "type": ["integer", "null"] | ||
| }, | ||
| "totalResponses": { | ||
| "type": ["integer", "null"] | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.