🐛 Source JIRA - Field correction bug causing stream connection to fail (

#18505) * max results field correction * added version notes and up * Update acceptance-test-config.yml * auto-bump connector version Co-authored-by: Vincent Koc <koconder@users.noreply.github.com> Co-authored-by: Vincent Koc <koconder@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Nov 7, 2022 · 3ffa11c · 3ffa11c
1 parent 99195c0
commit 3ffa11c
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 6 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -627,7 +627,7 @@
 - name: Jira
   sourceDefinitionId: 68e63de2-bb83-4c7e-93fa-a8a9051e3993
   dockerRepository: airbyte/source-jira
-  dockerImageTag: 0.2.22
+  dockerImageTag: 0.2.23
   documentationUrl: https://docs.airbyte.com/integrations/sources/jira
   icon: jira.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -5722,7 +5722,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-jira:0.2.22"
+- dockerImage: "airbyte/source-jira:0.2.23"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/jira"
     connectionSpecification:
@@ -5753,7 +5753,7 @@
           title: "Email"
           description: "The user email for your Jira account."
         max_results:
-          type: "number"
+          type: "integer"
           title: "Max Results"
           description: "Pagination max results (only for users stream)"
           default: 50

diff --git a/airbyte-integrations/connectors/source-jira/Dockerfile b/airbyte-integrations/connectors/source-jira/Dockerfile
@@ -12,5 +12,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.2.22
+LABEL io.airbyte.version=0.2.23
 LABEL io.airbyte.name=airbyte/source-jira
diff --git a/airbyte-integrations/connectors/source-jira/acceptance-test-config.yml b/airbyte-integrations/connectors/source-jira/acceptance-test-config.yml
@@ -4,6 +4,8 @@ connector_image: airbyte/source-jira:dev
 tests:
   spec:
     - spec_path: "source_jira/spec.json"
+      backward_compatibility_tests_config:
+        disable_for_version: "0.2.22"
   connection:
     - config_path: "secrets/config.json"
       status: "succeed"

diff --git a/airbyte-integrations/connectors/source-jira/source_jira/spec.json b/airbyte-integrations/connectors/source-jira/source_jira/spec.json
@@ -26,7 +26,7 @@
         "description": "The user email for your Jira account."
       },
       "max_results": {
-        "type": "number",
+        "type": "integer",
         "title": "Max Results",
         "description": "Pagination max results (only for users stream)",
         "default": 50

diff --git a/airbyte-integrations/connectors/source-jira/source_jira/streams.py b/airbyte-integrations/connectors/source-jira/source_jira/streams.py
@@ -1090,7 +1090,7 @@ def __init__(self, domain: str, projects: List[str], max_results: int, **kwargs)
         self._max_results = max_results
 
     def path(self, **kwargs) -> str:
-        if int(self._max_results) > 0:
+        if self._max_results > 0:
             return "user/search?maxResults=" + str(self._max_results) + "&query="
         return "user/search?query="
 

diff --git a/docs/integrations/sources/jira.md b/docs/integrations/sources/jira.md
@@ -95,6 +95,8 @@ The Jira connector should not run into Jira API limitations under normal usage.
 
 | Version | Date       | Pull Request                                                | Subject                                                                                                                 |
 |:--------|:-----------|:------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------|
+| 0.2.23  | 2022-10-28 | [\#18505](hhttps://github.com/airbytehq/airbyte/pull/18505) | Correcting `max_results` bug introduced in connector stream                                                                   |
+| 0.2.22  | 2022-10-03 | [\#16944](hhttps://github.com/airbytehq/airbyte/pull/16944) | Adds support for `max_results` to `users` stream                                                                   |
 | 0.2.22  | 2022-10-03 | [\#16944](hhttps://github.com/airbytehq/airbyte/pull/16944) | Adds support for `max_results` to `users` stream                                                                   |
 | 0.2.21  | 2022-07-28 | [\#15135](hhttps://github.com/airbytehq/airbyte/pull/15135) | Adds components to `fields` object on `issues` stream                                                                   |
 | 0.2.20  | 2022-05-25 | [\#13202](https://github.com/airbytehq/airbyte/pull/13202)  | Adds resolutiondate to `fields` object on `issues` stream                                                               |