Make return type of destination non-optional (#3381)

* Make return type of destination non-optional * Preload destinationDefinition * Audit fix
airbytehq · May 12, 2021 · 4889924 · 4889924
1 parent c1b4843
commit 4889924
Show file tree

Hide file tree

Showing 6 changed files with 117 additions and 100 deletions.
diff --git a/airbyte-webapp/package-lock.json b/airbyte-webapp/package-lock.json
diff --git a/airbyte-webapp/package.json b/airbyte-webapp/package.json
@@ -39,7 +39,7 @@
     "react-use": "^15.3.8",
     "react-widgets": "^4.5.0",
     "rest-hooks": "^5.0.20",
-    "sanitize-html": "^2.1.2",
+    "sanitize-html": "^2.3.3",
     "styled-components": "^5.1.1",
     "yup": "^0.28.1"
   },

diff --git a/airbyte-webapp/src/components/CreateConnectionContent/CreateConnectionContent.tsx b/airbyte-webapp/src/components/CreateConnectionContent/CreateConnectionContent.tsx
@@ -22,7 +22,7 @@ import { SyncSchema } from "core/domain/catalog";
 
 import useConnection from "components/hooks/services/useConnectionHook";
 import { useDiscoverSchema } from "components/hooks/services/useSchemaHook";
-import { useDestinationDefinitionSpecificationLoad } from "../hooks/services/useDestinationHook";
+import { useDestinationDefinitionSpecificationLoad } from "components/hooks/services/useDestinationHook";
 
 const SkipButton = styled.div`
   margin-top: 6px;
@@ -61,7 +61,6 @@ const CreateConnectionContent: React.FC<IProps> = ({
   } = useDiscoverSchema(source?.sourceId);
 
   const {
-    destinationDefinitionSpecification,
     isLoading: loadingDestination,
   } = useDestinationDefinitionSpecificationLoad(
     destination.destinationDefinitionId
@@ -153,7 +152,6 @@ const CreateConnectionContent: React.FC<IProps> = ({
           schema={schema}
           source={source}
           destination={destination}
-          destinationDefinition={destinationDefinitionSpecification}
         />
       </Suspense>
     </ContentCard>