add onesignal credentials + gradlew format (#7270)

airbytehq · Oct 22, 2021 · 4efadb2 · 4efadb2
1 parent 17961fc
commit 4efadb2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/publish-command.yml b/.github/workflows/publish-command.yml
@@ -189,6 +189,7 @@ jobs:
           SOURCE_TIKTOK_MARKETING_PROD_TEST_CREDS: ${{ secrets.SOURCE_TIKTOK_MARKETING_PROD_TEST_CREDS }}
           DESTINATION_DATABRICKS_CREDS: ${{ secrets.DESTINATION_DATABRICKS_CREDS }}
           MONGODB_TEST_CREDS: ${{ secrets.MONGODB_TEST_CREDS }}
+          SOURCE_ONESIGNAL_TEST_CREDS: ${{ secrets.SOURCE_ONESIGNAL_TEST_CREDS }}
       - run: |
           echo "$SPEC_CACHE_SERVICE_ACCOUNT_KEY" > spec_cache_key_file.json && docker login -u airbytebot -p ${DOCKER_PASSWORD}
           ./tools/integrations/manage.sh publish airbyte-integrations/${{ github.event.inputs.connector }} ${{ github.event.inputs.run-tests }} --publish_spec_to_cache

diff --git a/.github/workflows/test-command.yml b/.github/workflows/test-command.yml
@@ -184,6 +184,7 @@ jobs:
           SOURCE_TIKTOK_MARKETING_PROD_TEST_CREDS: ${{ secrets.SOURCE_TIKTOK_MARKETING_PROD_TEST_CREDS }}
           DESTINATION_DATABRICKS_CREDS: ${{ secrets.DESTINATION_DATABRICKS_CREDS }}
           MONGODB_TEST_CREDS: ${{ secrets.MONGODB_TEST_CREDS }}
+          SOURCE_ONESIGNAL_TEST_CREDS: ${{ secrets.SOURCE_ONESIGNAL_TEST_CREDS }}
       - run: |
           ./tools/bin/ci_integration_test.sh ${{ github.event.inputs.connector }}
         name: test ${{ github.event.inputs.connector }}

diff --git a/...ctors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java b/...ctors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
@@ -56,11 +56,11 @@ public JsonNode toDatabaseConfig(final JsonNode config) {
     final List<String> additionalParameters = new ArrayList<>();
 
     /*
-      The property useFetchSizeWithLongColumn required to select LONG or LONG RAW columns.
-      Oracle recommends avoiding LONG and LONG RAW columns. Use LOB instead. They are included in Oracle only for legacy reasons.
-      THIS IS A THIN ONLY PROPERTY. IT SHOULD NOT BE USED WITH ANY OTHER DRIVERS.
-      See https://docs.oracle.com/cd/E11882_01/appdev.112/e13995/oracle/jdbc/OracleDriver.html
-          https://docs.oracle.com/cd/B19306_01/java.102/b14355/jstreams.htm#i1014085
+     * The property useFetchSizeWithLongColumn required to select LONG or LONG RAW columns. Oracle
+     * recommends avoiding LONG and LONG RAW columns. Use LOB instead. They are included in Oracle only
+     * for legacy reasons. THIS IS A THIN ONLY PROPERTY. IT SHOULD NOT BE USED WITH ANY OTHER DRIVERS.
+     * See https://docs.oracle.com/cd/E11882_01/appdev.112/e13995/oracle/jdbc/OracleDriver.html
+     * https://docs.oracle.com/cd/B19306_01/java.102/b14355/jstreams.htm#i1014085
      */
     additionalParameters.add("oracle.jdbc.useFetchSizeWithLongColumn=true");
 

diff --git a/...test-integration/java/io/airbyte/integrations/source/oracle/OracleSourceDatatypeTest.java b/...test-integration/java/io/airbyte/integrations/source/oracle/OracleSourceDatatypeTest.java
@@ -266,7 +266,7 @@ protected void initTests() {
             .sourceType("LONG")
             .airbyteType(JsonSchemaPrimitive.STRING)
             .fullSourceDataType("LONG RAW")
-             .addInsertValues("utl_raw.cast_to_raw('some content here')", "null")
+            .addInsertValues("utl_raw.cast_to_raw('some content here')", "null")
             .addExpectedValues("c29tZSBjb250ZW50IGhlcmU=", null)
             .build());
 

diff --git a/tools/bin/ci_credentials.sh b/tools/bin/ci_credentials.sh
@@ -107,6 +107,7 @@ write_standard_creds source-mongodb-strict-encrypt "$MONGODB_TEST_CREDS" "creden
 write_standard_creds source-mongodb-v2 "$MONGODB_TEST_CREDS" "credentials.json"
 write_standard_creds source-mssql "$MSSQL_RDS_TEST_CREDS"
 write_standard_creds source-okta "$SOURCE_OKTA_TEST_CREDS"
+write_standard_creds source-onesignal "$SOURCE_ONESIGNAL_TEST_CREDS"
 write_standard_creds source-plaid "$PLAID_INTEGRATION_TEST_CREDS"
 write_standard_creds source-paypal-transaction "$PAYPAL_TRANSACTION_CREDS"
 write_standard_creds source-mysql "$MYSQL_SSH_KEY_TEST_CREDS" "ssh-key-config.json"
@@ -150,4 +151,3 @@ write_standard_creds source-zendesk-support "$ZENDESK_SUPPORT_OAUTH_TEST_CREDS"
 write_standard_creds source-zendesk-talk "$ZENDESK_TALK_TEST_CREDS"
 write_standard_creds source-zoom-singer "$ZOOM_INTEGRATION_TEST_CREDS"
 write_standard_creds source-zuora "$SOURCE_ZUORA_TEST_CREDS"
-