Skip to content

Commit

Permalink
📚 Add definition-of-done checklist for connectors into PR template (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
sherifnada committed Jun 3, 2021
1 parent 34da86c commit 5c7edee
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 26 deletions.
20 changes: 0 additions & 20 deletions .github/PULL_REQUEST_TEMPLATE/new_python_source.md

This file was deleted.

35 changes: 29 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,34 @@
## How
*Describe the solution*

## Recommended reading order
1. `x.java`
2. `y.python`

## Pre-merge Checklist
- [ ] *Run integration tests*
- [ ] *Publish Docker images*
Expand the checklist which is relevant for this PR.

<details><summary> <strong> Connector checklist </strong> </summary>
<p>

- [ ] Issue acceptance criteria met
- [ ] Unit & integration tests added as appropriate (and are passing)
* Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run `./gradlew :airbyte-integrations:connectors:<name>:integrationTest`.
- [ ] `/test` command documented [here]() is passing.
* Community members can skip this, Airbyters will run this for you.
- [ ] Code reviews completed
- [ ] Credentials added to Github CI if needed and not already present. [instructions for injecting secrets into CI](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#using-credentials-in-ci).
- [ ] Documentation updated
- [ ] README
- [ ] CHANGELOG.md
- [ ] Reference docs in the `docs/integrations/` directory.
- [ ] Build is successful
- [ ] Connector version bumped like described [here](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#updating-a-connector)
- [ ] New Connector version released on Dockerhub by running the `/publish` command described [here](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#updating-a-connector)
- [ ] No major blockers
- [ ] PR merged into master branch
- [ ] Follow up tickets have been created
- [ ] Associated tickets have been closed & stakeholders notified
</p>
</details>

## Recommended reading order
1. `test.java`
1. `component.ts`
1. the rest

0 comments on commit 5c7edee

Please sign in to comment.