Skip to content

Commit

Permalink
Add google cloud storage configuration in helm chart (#8332)
Browse files Browse the repository at this point in the history
* Add google cloud storage configuration in helm chart

* Fix GCS naming convention in helm chart

* Fix setting GCS_LOG_BUCKET in helm env-configmap

* Add quotes to gcs values in helm env-configmap

* Remove unnecessary 'default ' in helm env-configmap
  • Loading branch information
Nmaxime committed Dec 13, 2021
1 parent b1c067a commit 6854776
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
8 changes: 4 additions & 4 deletions charts/airbyte/Chart.lock
@@ -1,12 +1,12 @@
dependencies:
- name: common
repository: https://charts.bitnami.com/bitnami
version: 1.10.0
version: 1.10.1
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 10.12.2
version: 10.13.9
- name: minio
repository: https://charts.bitnami.com/bitnami
version: 7.3.2
digest: sha256:5f89ca9a82db41bcb9dce50e95a2abcafebce71b51be99760a670be30a3ec5c6
generated: "2021-10-08T12:41:40.511486438-05:00"
digest: sha256:51711092d4fb978667aaeadac5080241db1eb32d4a0d4d25c2a775110d013813
generated: "2021-11-30T11:54:53.849182827+01:00"
4 changes: 2 additions & 2 deletions charts/airbyte/templates/env-configmap.yaml
Expand Up @@ -17,8 +17,8 @@ data:
DATABASE_USER: {{ include "airbyte.database.user" . }}
DB_DOCKER_MOUNT: airbyte_db
FULLSTORY: {{ ternary "enabled" "disabled" .Values.webapp.fullstory.enabled }}
GCS_LOG_BUCKET: ""
GOOGLE_APPLICATION_CREDENTIALS: ""
GCS_LOG_BUCKET: {{ .Values.logs.gcs.bucket | quote }}
GOOGLE_APPLICATION_CREDENTIALS: {{ .Values.logs.gcs.credentials | quote }}
INTERNAL_API_HOST: {{ include "common.names.fullname" . }}-server:{{ .Values.server.service.port }}
IS_DEMO: {{ ternary "true" "false" .Values.webapp.isDemo | quote }}
JOB_POD_MAIN_CONTAINER_CPU_LIMIT: ""
Expand Down
7 changes: 7 additions & 0 deletions charts/airbyte/values.yaml
Expand Up @@ -542,3 +542,10 @@ logs:
enabled: false
bucket: airbyte-dev-logs
bucketRegion: ""

## Google Cloud Storage (GCS) Log Location Configuration
## @param gcs.bucket GCS bucket name
## @param gcs.credentials The path the GCS creds are written to
gcs:
bucket: ""
credentials: ""

0 comments on commit 6854776

Please sign in to comment.