Publish Pubsub (#4354)

airbytehq · Jun 25, 2021 · 767f40b · 767f40b
1 parent 8bce174
commit 767f40b
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/publish-command.yml b/.github/workflows/publish-command.yml
@@ -58,6 +58,7 @@ jobs:
           AZURE_STORAGE_INTEGRATION_TEST_CREDS: ${{ secrets.AZURE_STORAGE_INTEGRATION_TEST_CREDS }}
           BIGQUERY_INTEGRATION_TEST_CREDS: ${{ secrets.BIGQUERY_INTEGRATION_TEST_CREDS }}
           BRAINTREE_TEST_CREDS: ${{ secrets.BRAINTREE_TEST_CREDS }}
+          DESTINATION_PUBSUB_TEST_CREDS: ${{ secrets.DESTINATION_PUBSUB_TEST_CREDS }}
           DRIFT_INTEGRATION_TEST_CREDS: ${{ secrets.DRIFT_INTEGRATION_TEST_CREDS }}
           EXCHANGE_RATES_TEST_CREDS: ${{ secrets.EXCHANGE_RATES_TEST_CREDS }}
           FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS }}

diff --git a/.github/workflows/test-command.yml b/.github/workflows/test-command.yml
@@ -58,6 +58,7 @@ jobs:
           AZURE_STORAGE_INTEGRATION_TEST_CREDS: ${{ secrets.AZURE_STORAGE_INTEGRATION_TEST_CREDS }}
           BIGQUERY_INTEGRATION_TEST_CREDS: ${{ secrets.BIGQUERY_INTEGRATION_TEST_CREDS }}
           BRAINTREE_TEST_CREDS: ${{ secrets.BRAINTREE_TEST_CREDS }}
+          DESTINATION_PUBSUB_TEST_CREDS: ${{ secrets.DESTINATION_PUBSUB_TEST_CREDS }}
           DRIFT_INTEGRATION_TEST_CREDS: ${{ secrets.DRIFT_INTEGRATION_TEST_CREDS }}
           EXCHANGE_RATES_TEST_CREDS: ${{ secrets.EXCHANGE_RATES_TEST_CREDS }}
           FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS }}

diff --git a/...ation-pubsub/src/main/java/io/airbyte/integrations/destination/pubsub/PubsubConsumer.java b/...ation-pubsub/src/main/java/io/airbyte/integrations/destination/pubsub/PubsubConsumer.java
@@ -21,6 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
+
 package io.airbyte.integrations.destination.pubsub;
 
 import com.fasterxml.jackson.databind.JsonNode;
@@ -61,8 +62,8 @@ public class PubsubConsumer extends FailureTrackingAirbyteMessageConsumer {
   private AirbyteMessage lastStateMessage;
 
   public PubsubConsumer(JsonNode config,
-      ConfiguredAirbyteCatalog catalog,
-      Consumer<AirbyteMessage> outputRecordCollector) {
+                        ConfiguredAirbyteCatalog catalog,
+                        Consumer<AirbyteMessage> outputRecordCollector) {
     this.outputRecordCollector = outputRecordCollector;
     this.config = config;
     this.catalog = catalog;
@@ -136,4 +137,5 @@ protected void close(boolean hasFailed) throws Exception {
       outputRecordCollector.accept(lastStateMessage);
     }
   }
+
 }
diff --git a/...on-pubsub/src/main/java/io/airbyte/integrations/destination/pubsub/PubsubDestination.java b/...on-pubsub/src/main/java/io/airbyte/integrations/destination/pubsub/PubsubDestination.java
@@ -96,8 +96,9 @@ public AirbyteConnectionStatus check(JsonNode config) {
 
   @Override
   public AirbyteMessageConsumer getConsumer(JsonNode config,
-      ConfiguredAirbyteCatalog configuredCatalog,
-      Consumer<AirbyteMessage> outputRecordCollector) {
+                                            ConfiguredAirbyteCatalog configuredCatalog,
+                                            Consumer<AirbyteMessage> outputRecordCollector) {
     return new PubsubConsumer(config, configuredCatalog, outputRecordCollector);
   }
+
 }
diff --git a/...tion/java/io/airbyte/integrations/destination/pubsub/PubsubDestinationAcceptanceTest.java b/...tion/java/io/airbyte/integrations/destination/pubsub/PubsubDestinationAcceptanceTest.java
@@ -79,7 +79,8 @@ public class PubsubDestinationAcceptanceTest extends DestinationAcceptanceTest {
   private ProjectSubscriptionName subscriptionName;
   private Credentials credentials;
   private JsonNode configJson;
-  // Store retrieved data during the test run since we can't re-read it multiple times (ACKing messages causes them to be removed from pubsub)
+  // Store retrieved data during the test run since we can't re-read it multiple times (ACKing
+  // messages causes them to be removed from pubsub)
   private List<JsonNode> records;
 
   @Override
@@ -120,7 +121,7 @@ protected List<JsonNode> retrieveRecords(TestDestinationEnv testEnv,
       // verification
       SubscriberStubSettings subscriberStubSettings =
           SubscriberStubSettings.newBuilder()
-          .setCredentialsProvider(FixedCredentialsProvider.create(credentials))
+              .setCredentialsProvider(FixedCredentialsProvider.create(credentials))
               .setTransportChannelProvider(
                   SubscriberStubSettings.defaultGrpcTransportProviderBuilder()
                       .setCredentials(credentials)

diff --git a/tools/bin/ci_credentials.sh b/tools/bin/ci_credentials.sh
@@ -23,6 +23,7 @@ function write_standard_creds() {
 
 write_standard_creds destination-bigquery "$BIGQUERY_INTEGRATION_TEST_CREDS" "credentials.json"
 write_standard_creds destination-bigquery-denormalized "$BIGQUERY_INTEGRATION_TEST_CREDS" "credentials.json"
+write_standard_creds destination-pubsub "$DESTINATION_PUBSUB_TEST_CREDS" "credentials.json"
 write_standard_creds destination-snowflake "$SNOWFLAKE_INTEGRATION_TEST_CREDS" "insert_config.json"
 write_standard_creds destination-snowflake "$SNOWFLAKE_S3_COPY_INTEGRATION_TEST_CREDS" "copy_s3_config.json"
 write_standard_creds destination-snowflake "$SNOWFLAKE_GCS_COPY_INTEGRATION_TEST_CREDS" "copy_gcs_config.json"