Skip to content

Commit

Permalink
Source notion: fix schema (#20639)
Browse files Browse the repository at this point in the history
* #1047 oncall - Source Notion: fix Pages stream schema

* #1047 oncall - Source Notion: fix Pages stream schema

* #1047 oncall - Source Notion: upd changelog

* #1047 source notion - remove ignored fields

* #1047 source notion: fix SATs

* #1047 source notion: upd expected records

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
davydov-d and octavia-squidington-iii committed Jan 11, 2023
1 parent 2769f88 commit 9d4dd48
Show file tree
Hide file tree
Showing 9 changed files with 162 additions and 113 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@
- name: Notion
sourceDefinitionId: 6e00b415-b02e-4160-bf02-58176a0ae687
dockerRepository: airbyte/source-notion
dockerImageTag: 0.1.10
dockerImageTag: 1.0.0
documentationUrl: https://docs.airbyte.com/integrations/sources/notion
icon: notion.svg
sourceType: api
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9706,7 +9706,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-notion:0.1.10"
- dockerImage: "airbyte/source-notion:1.0.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/notion"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-notion/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_notion ./source_notion
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.10
LABEL io.airbyte.version=1.0.0
LABEL io.airbyte.name=airbyte/source-notion
Original file line number Diff line number Diff line change
@@ -1,28 +1,34 @@
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-notion:dev
tests:
test_strictness_level: high
acceptance_tests:
spec:
- spec_path: "source_notion/spec.json"
tests:
- spec_path: "source_notion/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
tests:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.txt.jsonl"
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/incremental_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
"pages": ["icon"]
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,52 @@
"stream": {
"name": "users",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
"supported_sync_modes": ["full_refresh"],
"default_primary_key": [["id"]]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
"destination_sync_mode": "overwrite",
"primary_key": [["id"]]
},
{
"stream": {
"name": "databases",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "pages",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "blocks",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
}
Expand Down

0 comments on commit 9d4dd48

Please sign in to comment.