ci-credentials: fix typo when no secret found (#20353)

airbytehq · Dec 12, 2022 · 9eca59e · 9eca59e
1 parent da6a015
commit 9eca59e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/tools/ci_credentials/ci_credentials/secrets_manager.py b/tools/ci_credentials/ci_credentials/secrets_manager.py
@@ -181,8 +181,6 @@ def write_to_storage(self, secrets: List[RemoteSecret]) -> List[Path]:
             List[Path]: List of paths were the secrets were written
         """
         written_files = []
-        if not secrets:
-            return 0
         for secret in secrets:
             secrets_dir = self.base_folder / secret.directory
             secrets_dir.mkdir(parents=True, exist_ok=True)

diff --git a/tools/ci_credentials/setup.py b/tools/ci_credentials/setup.py
@@ -10,7 +10,7 @@
 TEST_REQUIREMENTS = ["requests-mock", "pytest"]
 
 setup(
-    version="1.0.0",
+    version="1.0.1",
     name="ci_credentials",
     description="CLI tooling to read and manage GSM secrets",
     author="Airbyte",

diff --git a/tools/ci_credentials/tests/test_secrets_manager.py b/tools/ci_credentials/tests/test_secrets_manager.py
@@ -121,6 +121,11 @@ def test_read(matchers, connector_name, gsm_secrets, expected_secrets):
                 "airbyte-integrations/bases/base-normalization/secrets/auth.json",
             ],
         ),
+        (
+            "source-no-secret",
+            [],
+            [],
+        ),
     ),
 )
 def test_write(tmp_path, connector_name, secrets, expected_files):