Skip to content

Commit

Permalink
🐛Source LinkedIn Ads: Fix Readme commands, change spec from json to y…
Browse files Browse the repository at this point in the history
…aml (#39442)
  • Loading branch information
btkcodedev committed Jun 14, 2024
1 parent c7f885f commit a44bbfa
Show file tree
Hide file tree
Showing 7 changed files with 189 additions and 180 deletions.
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-linkedin-ads/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ poetry install --with dev
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/linkedin-ads)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_linkedin_ads/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `sample_files/sample_config.json` for a sample config file.
See `integration_tests/sample_config.json` for a sample config file.

### Locally running the connector

```
poetry run source-linkedin-ads spec
poetry run source-linkedin-ads check --config secrets/config.json
poetry run source-linkedin-ads discover --config secrets/config.json
poetry run source-linkedin-ads read --config secrets/config.json --catalog sample_files/configured_catalog.json
poetry run source-linkedin-ads read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Running unit tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test_strictness_level: high
acceptance_tests:
spec:
tests:
- spec_path: "source_linkedin_ads/spec.json"
- spec_path: "source_linkedin_ads/spec.yaml"
config_path: "secrets/config_oauth.json"
connection:
tests:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 137ece28-5434-455c-8f34-69dc3782f451
dockerImageTag: 2.1.3
dockerImageTag: 2.1.4
dockerRepository: airbyte/source-linkedin-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-ads
githubIssueLabel: source-linkedin-ads
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "2.1.3"
version = "2.1.4"
name = "source-linkedin-ads"
description = "Source implementation for Linkedin Ads."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down

This file was deleted.

Loading

0 comments on commit a44bbfa

Please sign in to comment.