🐛 Source Freshdesk: Added nullable to all stream schemas, added trans…

…formation into declared schema types (#17249)
airbytehq · Sep 27, 2022 · a55e9e7 · a55e9e7
1 parent 896c2c9
commit a55e9e7
Show file tree

Hide file tree

Showing 31 changed files with 181 additions and 162 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -315,7 +315,7 @@
 - name: Freshdesk
   sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
   dockerRepository: airbyte/source-freshdesk
-  dockerImageTag: 0.3.4
+  dockerImageTag: 0.3.5
   documentationUrl: https://docs.airbyte.io/integrations/sources/freshdesk
   icon: freshdesk.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -3230,7 +3230,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-freshdesk:0.3.4"
+- dockerImage: "airbyte/source-freshdesk:0.3.5"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/sources/freshdesk"
     connectionSpecification:

diff --git a/airbyte-integrations/connectors/source-freshdesk/Dockerfile b/airbyte-integrations/connectors/source-freshdesk/Dockerfile
@@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.3.4
+LABEL io.airbyte.version=0.3.5
 LABEL io.airbyte.name=airbyte/source-freshdesk
diff --git a/airbyte-integrations/connectors/source-freshdesk/README.md b/airbyte-integrations/connectors/source-freshdesk/README.md
@@ -88,6 +88,17 @@ docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files
 1. To run additional integration tests, place your integration tests in a new directory `integration_tests` and run them with `python -m pytest -s integration_tests`.
    Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
 
+#### Acceptance Tests
+Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](../../../docs/connector-development/testing-connectors/source-acceptance-tests-reference.md) for more information.
+If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
+To run your integration tests with acceptance tests, from the connector root, run
+```
+docker build . --no-cache -t airbyte/source-freshdesk:dev \
+&& python -m pytest -p integration_tests.acceptance
+```
+To run your integration tests with docker
+
+
 ## Dependency Management
 All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
 

diff --git a/airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml b/airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml
@@ -11,6 +11,9 @@ tests:
       status: "failed"
   discovery:
     - config_path: "secrets/config.json"
+    # please remove the backward_capability checks bypass, once updated to the newer version
+      backward_compatibility_tests_config:
+        disable_for_version: "0.3.4"
   basic_read:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"

diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/agents.json b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/agents.json
@@ -3,25 +3,25 @@
   "type": "object",
   "properties": {
     "available": {
-      "type": "boolean"
+      "type": ["boolean", "null"]
     },
     "occasional": {
-      "type": "boolean"
+      "type": ["boolean", "null"]
     },
     "id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "signature": {
       "type": ["string", "null"]
     },
     "ticket_scope": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "last_active_at": {
       "type": ["string", "null"]
@@ -30,43 +30,43 @@
       "type": ["string", "null"]
     },
     "type": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "contact": {
-      "type": "object",
+      "type": ["null", "object"],
       "properties": {
         "active": {
-          "type": "boolean"
+          "type": ["boolean", "null"]
         },
         "email": {
-          "type": "string"
+          "type": ["string", "null"]
         },
         "job_title": {
           "type": ["string", "null"]
         },
         "language": {
-          "type": "string"
+          "type": ["string", "null"]
         },
         "last_login_at": {
           "type": ["string", "null"]
         },
         "mobile": {
-          "type": ["string", "integer", "null"]
+          "type": ["string", "null"]
         },
         "name": {
-          "type": "string"
+          "type": ["string", "null"]
         },
         "phone": {
-          "type": ["string", "integer", "null"]
+          "type": ["string", "null"]
         },
         "time_zone": {
-          "type": "string"
+          "type": ["string", "null"]
         },
         "created_at": {
-          "type": "string"
+          "type": ["string", "null"]
         },
         "updated_at": {
-          "type": "string"
+          "type": ["string", "null"]
         }
       }
     }

diff --git a/...yte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/business_hours.json b/...yte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/business_hours.json
@@ -100,10 +100,10 @@
       }
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     }
   }
 }
diff --git a/...rations/connectors/source-freshdesk/source_freshdesk/schemas/canned_response_folders.json b/...rations/connectors/source-freshdesk/source_freshdesk/schemas/canned_response_folders.json
@@ -15,10 +15,10 @@
       "type": ["null", "integer"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     }
   }
 }
diff --git a/...e-integrations/connectors/source-freshdesk/source_freshdesk/schemas/canned_responses.json b/...e-integrations/connectors/source-freshdesk/source_freshdesk/schemas/canned_responses.json
@@ -41,19 +41,19 @@
             "type": ["null", "string"]
           },
           "created_at": {
-            "type": "string"
+            "type": ["string", "null"]
           },
           "updated_at": {
-            "type": "string"
+            "type": ["string", "null"]
           }
         }
       }
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     }
   }
 }
diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/companies.json b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/companies.json
@@ -3,10 +3,10 @@
   "type": "object",
   "properties": {
     "id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "name": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "description": {
       "type": ["string", "null"]
@@ -15,19 +15,19 @@
       "type": ["string", "null"]
     },
     "domains": {
-      "type": "array",
+      "type": ["array", "null"],
       "items": {
-        "type": "string"
+        "type": ["string", "null"]
       }
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "custom_fields": {
-      "type": "object"
+      "type": ["object", "null"]
     },
     "health_score": {
       "type": ["string", "null"]

diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/contacts.json b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/contacts.json
@@ -3,7 +3,7 @@
   "type": "object",
   "properties": {
     "active": {
-      "type": "boolean"
+      "type": ["boolean", "null"]
     },
     "address": {
       "type": ["string", "null"]
@@ -15,43 +15,43 @@
       "type": ["string", "null"]
     },
     "email": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "job_title": {
       "type": ["string", "null"]
     },
     "language": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "mobile": {
-      "type": ["string", "integer", "null"]
+      "type": ["string", "null"]
     },
     "name": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "phone": {
-      "type": ["string", "integer", "null"]
+      "type": ["string", "null"]
     },
     "time_zone": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "twitter_id": {
       "type": ["integer", "null"]
     },
     "custom_fields": {
-      "type": "object"
+      "type": ["object", "null"]
     },
     "facebook_id": {
       "type": ["integer", "null"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "csat_rating": {
       "type": ["integer", "null"]

diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/conversations.json b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/conversations.json
@@ -3,31 +3,31 @@
   "type": "object",
   "properties": {
     "body": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "body_text": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "incoming": {
-      "type": "boolean"
+      "type": ["boolean", "null"]
     },
     "private": {
-      "type": "boolean"
+      "type": ["boolean", "null"]
     },
     "user_id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "support_email": {
       "type": ["string", "null"]
     },
     "source": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "category": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "to_emails": {
       "type": ["array", "null"]
@@ -42,16 +42,16 @@
       "type": ["array", "null"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["string", "null"]
     },
     "attachments": {
       "type": ["array", "null"]
     },
     "ticket_id": {
-      "type": "integer"
+      "type": ["integer", "null"]
     },
     "source_additional_info": {
       "type": ["object", "null"]

diff --git a/...egrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_categories.json b/...egrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_categories.json
@@ -12,10 +12,10 @@
       "type": ["null", "string"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["null", "string"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["null", "string"]
     }
   }
 }
diff --git a/...ntegrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_comments.json b/...ntegrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_comments.json
@@ -30,10 +30,10 @@
       "type": ["null", "integer"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["null", "string"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["null", "string"]
     }
   }
 }
diff --git a/...-integrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_topics.json b/...-integrations/connectors/source-freshdesk/source_freshdesk/schemas/discussion_topics.json
@@ -42,10 +42,10 @@
       "type": ["null", "integer"]
     },
     "created_at": {
-      "type": "string"
+      "type": ["null", "string"]
     },
     "updated_at": {
-      "type": "string"
+      "type": ["null", "string"]
     }
   }
 }