Publish PR 6967: new source freshservices (#7470)

* add first table * add other sources and incremental sync * clean up * fix schema * fix unit tests and linting * Update airbyte-integrations/connectors/source-freshservice/integration_tests/invalid_config.json Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> * Update airbyte-integrations/connectors/source-freshservice/Dockerfile Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> * Update airbyte-integrations/connectors/source-freshservice/setup.py Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> * clean up * change schema & more clean up * final touch * add null for object and array * final touch * fix config * fix integration test * add unit test * bump connector version and format files Co-authored-by: Tuan Nguyen <anhtuan.nguyen@me.com> Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com>
airbytehq · Oct 29, 2021 · ab95855 · ab95855
1 parent facdf85
commit ab95855
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/...ain/resources/config/STANDARD_SOURCE_DEFINITION/9bb85338-ea95-4c93-b267-6be89125b267.json b/...ain/resources/config/STANDARD_SOURCE_DEFINITION/9bb85338-ea95-4c93-b267-6be89125b267.json
@@ -0,0 +1,7 @@
+{
+  "sourceDefinitionId": "9bb85338-ea95-4c93-b267-6be89125b267",
+  "name": "Freshservice",
+  "dockerRepository": "airbyte/source-freshservice",
+  "dockerImageTag": "0.1.0",
+  "documentationUrl": "https://docs.airbyte.io/integrations/sources/freshservice"
+}
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -150,6 +150,13 @@
   documentationUrl: https://docs.airbyte.io/integrations/sources/freshdesk
   icon: freshdesk.svg
   sourceType: api
+- name: Freshservice
+  sourceDefinitionId: 9bb85338-ea95-4c93-b267-6be89125b267
+  dockerRepository: airbyte/source-freshservice
+  dockerImageTag: 0.1.0
+  documentationUrl: https://docs.airbyte.io/integrations/sources/freshservice
+  icon: freshdesk.svg
+  sourceType: api
 - name: GitHub
   sourceDefinitionId: ef69ef6e-aa7f-4af1-a01d-ef775033524e
   dockerRepository: airbyte/source-github

diff --git a/...tions/io/airbyte/integration_tests/sources/AbstractSshClickHouseSourceAcceptanceTest.java b/...tions/io/airbyte/integration_tests/sources/AbstractSshClickHouseSourceAcceptanceTest.java
@@ -5,11 +5,8 @@
 package io.airbyte.integrations.io.airbyte.integration_tests.sources;
 
 import com.fasterxml.jackson.databind.JsonNode;
-import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 import io.airbyte.commons.json.Jsons;
-import io.airbyte.commons.resources.MoreResources;
-import io.airbyte.db.Database;
 import io.airbyte.db.Databases;
 import io.airbyte.db.jdbc.JdbcDatabase;
 import io.airbyte.db.jdbc.JdbcUtils;
@@ -30,7 +27,6 @@
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
-import org.jooq.SQLDialect;
 import org.testcontainers.containers.ClickHouseContainer;
 
 public abstract class AbstractSshClickHouseSourceAcceptanceTest extends SourceAcceptanceTest {
@@ -99,6 +95,7 @@ protected void setupEnvironment(final TestDestinationEnv environment) throws Exc
     populateDatabaseTestData();
 
   }
+
   private void startTestContainers() {
     bastion.initAndStartBastion();
     initAndStartJdbcContainer();

diff --git a/...yte/integrations/io/airbyte/integration_tests/sources/ClickHouseSourceAcceptanceTest.java b/...yte/integrations/io/airbyte/integration_tests/sources/ClickHouseSourceAcceptanceTest.java
@@ -8,7 +8,6 @@
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 import io.airbyte.commons.json.Jsons;
-import io.airbyte.commons.resources.MoreResources;
 import io.airbyte.db.Databases;
 import io.airbyte.db.jdbc.JdbcDatabase;
 import io.airbyte.db.jdbc.JdbcUtils;