🐛 Source Slack: add float_ts field (#4683)

* rename float_ts to ts cursor_field * add float_ts * change float_ts to number * change channel_msg * bump version * increase default timeout_seconds slack acc test * timeout_seconds to 1750 * timeout_seconds to 3600 :p * add changelog for slack connector
airbytehq · Jul 14, 2021 · b110738 · b110738
1 parent ea7b0b0
commit b110738
Show file tree

Hide file tree

Showing 9 changed files with 24 additions and 5 deletions.
diff --git a/...ain/resources/config/STANDARD_SOURCE_DEFINITION/c2281cee-86f9-4a86-bb48-d23286b4c7bd.json b/...ain/resources/config/STANDARD_SOURCE_DEFINITION/c2281cee-86f9-4a86-bb48-d23286b4c7bd.json
@@ -2,7 +2,7 @@
   "sourceDefinitionId": "c2281cee-86f9-4a86-bb48-d23286b4c7bd",
   "name": "Slack",
   "dockerRepository": "airbyte/source-slack",
-  "dockerImageTag": "0.1.7",
+  "dockerImageTag": "0.1.8",
   "documentationUrl": "https://hub.docker.com/repository/docker/airbyte/source-slack",
   "icon": "slack.svg"
 }
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -335,7 +335,7 @@
 - sourceDefinitionId: c2281cee-86f9-4a86-bb48-d23286b4c7bd
   name: Slack
   dockerRepository: airbyte/source-slack
-  dockerImageTag: 0.1.7
+  dockerImageTag: 0.1.8
   documentationUrl: https://hub.docker.com/repository/docker/airbyte/source-slack
   icon: slack.svg
 - sourceDefinitionId: 6ff047c0-f5d5-4ce5-8c81-204a830fa7e1

diff --git a/airbyte-integrations/connectors/source-slack/Dockerfile b/airbyte-integrations/connectors/source-slack/Dockerfile
@@ -16,5 +16,5 @@ RUN pip install .
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.7
+LABEL io.airbyte.version=0.1.8
 LABEL io.airbyte.name=airbyte/source-slack
diff --git a/airbyte-integrations/connectors/source-slack/acceptance-test-config.yml b/airbyte-integrations/connectors/source-slack/acceptance-test-config.yml
@@ -16,6 +16,7 @@ tests:
   incremental:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
+      timeout_seconds: 3600
       cursor_paths:
         channel_messages: ["float_ts"]
   full_refresh:

diff --git a/airbyte-integrations/connectors/source-slack/integration_tests/configured_catalog.json b/airbyte-integrations/connectors/source-slack/integration_tests/configured_catalog.json
@@ -192,6 +192,9 @@
             "ts": {
               "type": ["null", "string"]
             },
+            "float_ts": {
+              "type": ["null", "number"]
+            },
             "type": {
               "type": ["null", "string"]
             },

diff --git a/airbyte-integrations/connectors/source-slack/sample_files/configured_catalog.json b/airbyte-integrations/connectors/source-slack/sample_files/configured_catalog.json
@@ -24,6 +24,9 @@
               "type": ["null", "string"]
             },
             "ts": {
+              "type": ["null", "string"]
+            },
+            "float_ts": {
               "type": ["null", "number"]
             },
             "team": {
@@ -66,9 +69,9 @@
         },
         "supported_sync_modes": ["full_refresh", "incremental"],
         "source_defined_cursor": true,
-        "default_cursor_field": ["ts"]
+        "default_cursor_field": ["float_ts"]
       },
-      "cursor_field": ["ts"],
+      "cursor_field": ["float_ts"],
       "sync_mode": "incremental",
       "destination_sync_mode": "append"
     }

diff --git a/airbyte-integrations/connectors/source-slack/source_slack/schemas/channel_messages.json b/airbyte-integrations/connectors/source-slack/source_slack/schemas/channel_messages.json
@@ -186,6 +186,9 @@
     "ts": {
       "type": ["null", "string"]
     },
+    "float_ts": {
+      "type": ["null", "number"]
+    },
     "type": {
       "type": ["null", "string"]
     },

diff --git a/airbyte-integrations/connectors/source-slack/source_slack/schemas/threads.json b/airbyte-integrations/connectors/source-slack/source_slack/schemas/threads.json
@@ -18,6 +18,9 @@
       "type": ["null", "string"]
     },
     "ts": {
+      "type": ["null", "string"]
+    },
+    "float_ts": {
       "type": ["null", "number"]
     },
     "team": {

diff --git a/docs/integrations/sources/slack.md b/docs/integrations/sources/slack.md
@@ -97,3 +97,9 @@ You can no longer create "Legacy" API Keys, but if you already have one, you can
 
 We recommend creating a restricted, read-only key specifically for Airbyte access. This will allow you to control which resources Airbyte should be able to access.
 
+## Changelog
+
+| Version | Date       | Pull Request | Subject |
+| :------ | :--------  | :-----       | :------ |
+| 0.1.8   | 2021-07-14 | [4683](https://github.com/airbytehq/airbyte/pull/4683) | Add float_ts primary key |
+| 0.1.7   | 2021-06-25 | [3978](https://github.com/airbytehq/airbyte/pull/3978) | Release Slack CDK Connector |