[ISSUE #38154] temporarily remove wish_bid from fields (#38301)

airbytehq · May 17, 2024 · b119353 · b119353
1 parent 6ea7957
commit b119353
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml b/airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml
@@ -10,7 +10,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c
-  dockerImageTag: 2.1.8
+  dockerImageTag: 2.1.9
   dockerRepository: airbyte/source-facebook-marketing
   documentationUrl: https://docs.airbyte.com/integrations/sources/facebook-marketing
   githubIssueLabel: source-facebook-marketing

diff --git a/airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml b/airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "2.1.8"
+version = "2.1.9"
 name = "source-facebook-marketing"
 description = "Source implementation for Facebook Marketing."
 authors = [ "Airbyte <contact@airbyte.io>",]

diff --git a/...ctors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py b/...ctors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py
@@ -371,4 +371,11 @@ def fields(self, **kwargs) -> List[str]:
 
         schema = ResourceSchemaLoader(package_name_from_class(self.__class__)).get_schema("ads_insights")
         self._fields = list(schema.get("properties", {}).keys())
+
+        # Having this field in syncs seem to have caused data inaccuracy where fields like `spend` had the wrong values
+        try:
+            self._fields.remove("wish_bid")
+        except ValueError:
+            pass
+
         return self._fields
diff --git a/...s/source-facebook-marketing/unit_tests/integration/test_ads_insights_action_product_id.py b/...s/source-facebook-marketing/unit_tests/integration/test_ads_insights_action_product_id.py
@@ -155,7 +155,6 @@ def _job_start_request(
             "video_time_watched_actions",
             "website_ctr",
             "website_purchase_roas",
-            "wish_bid",
         ],
         "time_increment": 1,
         "action_attribution_windows": ["1d_click", "7d_click", "28d_click", "1d_view", "7d_view", "28d_view"],

diff --git a/docs/integrations/sources/facebook-marketing.md b/docs/integrations/sources/facebook-marketing.md
@@ -202,6 +202,7 @@ The Facebook Marketing connector uses the `lookback_window` parameter to repeate
 
 | Version | Date       | Pull Request                                             | Subject                                                                                                                                                                                                                                                                                           |
 |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 2.1.9   | 2024-05-17 | [38301](https://github.com/airbytehq/airbyte/pull/38301) | Fix data inaccuracies when `wish_bid` is requested                                                                                                                                                                                                                                                |
 | 2.1.8   | 2024-05-07 | [37771](https://github.com/airbytehq/airbyte/pull/37771) | Handle errors without API error codes/messages                                                                                                                                                                                                                                                    |
 | 2.1.7   | 2024-04-24 | [36634](https://github.com/airbytehq/airbyte/pull/36634) | Update to CDK 0.80.0                                                                                                                                                                                                                                                                              |
 | 2.1.6   | 2024-04-24 | [36634](https://github.com/airbytehq/airbyte/pull/36634) | Schema descriptions                                                                                                                                                                                                                                                                               |