Skip to content

Commit

Permalink
🐛 Source GitHub: fix bug with IssueEvents stream and add handling f…
Browse files Browse the repository at this point in the history
…or rate limiting (#4708)

* Few updates for GitHub source

Set correct `cursor_field` for `IssueEvents` stream.
Add rate limit handling.
Add handling for 403 error.
Add handling for 502 error.

Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
  • Loading branch information
3 people committed Jul 15, 2021
1 parent baed7b4 commit b405c9c
Show file tree
Hide file tree
Showing 6 changed files with 207 additions and 77 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "ef69ef6e-aa7f-4af1-a01d-ef775033524e",
"name": "GitHub",
"dockerRepository": "airbyte/source-github",
"dockerImageTag": "0.1.1",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-github",
"dockerImageTag": "0.1.2",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/github",
"icon": "github.svg"
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
- sourceDefinitionId: ef69ef6e-aa7f-4af1-a01d-ef775033524e
name: GitHub
dockerRepository: airbyte/source-github
dockerImageTag: 0.1.1
documentationUrl: https://hub.docker.com/r/airbyte/source-github
dockerImageTag: 0.1.2
documentationUrl: https://docs.airbyte.io/integrations/sources/github
icon: github.svg
- sourceDefinitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1
name: Microsoft SQL Server (MSSQL)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-github/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.name=airbyte/source-github
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,23 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) ->
def streams(self, config: Mapping[str, Any]) -> List[Stream]:
authenticator = TokenAuthenticator(token=config["access_token"], auth_method="token")
full_refresh_args = {"authenticator": authenticator, "repository": config["repository"]}
incremental_args = {"authenticator": authenticator, "repository": config["repository"], "start_date": config["start_date"]}
incremental_args = {**full_refresh_args, "start_date": config["start_date"]}

return [
Assignees(**full_refresh_args),
Reviews(**full_refresh_args),
Collaborators(**full_refresh_args),
Teams(**full_refresh_args),
IssueLabels(**full_refresh_args),
Releases(**incremental_args),
Events(**incremental_args),
Comments(**incremental_args),
PullRequests(**incremental_args),
CommitComments(**incremental_args),
IssueMilestones(**incremental_args),
Commits(**incremental_args),
Stargazers(**incremental_args),
Projects(**incremental_args),
Issues(**incremental_args),
Events(**incremental_args),
IssueEvents(**incremental_args),
IssueLabels(**full_refresh_args),
IssueMilestones(**incremental_args),
Issues(**incremental_args),
Projects(**incremental_args),
PullRequests(**incremental_args),
Releases(**incremental_args),
Reviews(**full_refresh_args),
Stargazers(**incremental_args),
Teams(**full_refresh_args),
]

0 comments on commit b405c9c

Please sign in to comment.