Skip to content

Commit

Permalink
🎉 New source: Google PageSpeed Insights [low-code CDK] (#19813)
Browse files Browse the repository at this point in the history
* New source: Google PageSpeed Insights

* update PR number

* Connector re-definition to use stream slices

So far, the connector used one single URL and
categories and strategies hardcoded in the
connector definition.
This commit changes the connector by removing
the second stream (origin) and uses ListStreamSlicers
for url, strategy and category to allow for better
configuration.

* fixed timeout for check int. tests

* use new pagespeed insights logo

* sample_config

* add strategy and category to stream

* use only one request for all defined categories

* fix lighthosue results schema

* remove required from schema

* remove audit and category details in schema

* add strategy field to schema

* auto-bump connector version

Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
3 people committed Dec 14, 2022
1 parent 863d8da commit b6c6b7a
Show file tree
Hide file tree
Showing 25 changed files with 993 additions and 0 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,14 @@
icon: googledirectory.svg
sourceType: api
releaseStage: alpha
- name: Google PageSpeed Insights
sourceDefinitionId: 1e9086ab-ddac-4c1d-aafd-ba43ff575fe4
dockerRepository: airbyte/source-google-pagespeed-insights
dockerImageTag: 0.1.0
documentationUrl: https://docs.airbyte.com/integrations/sources/google-pagespeed-insights
icon: google-pagespeed-insights.svg
sourceType: api
releaseStage: alpha
- name: Google Search Console
sourceDefinitionId: eb4c9e00-db83-4d63-a386-39cfa91012a8
dockerRepository: airbyte/source-google-search-console
Expand Down
59 changes: 59 additions & 0 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5574,6 +5574,65 @@
- - "client_secret"
oauthFlowOutputParameters:
- - "refresh_token"
- dockerImage: "airbyte/source-google-pagespeed-insights:0.1.0"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/sources/google-pagespeed-insights"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "Google PageSpeed Insights Spec"
type: "object"
required:
- "urls"
- "strategies"
- "categories"
additionalProperties: true
properties:
api_key:
type: "string"
title: "API Key"
description: "Google PageSpeed API Key. See <a href=\"https://developers.google.com/speed/docs/insights/v5/get-started#APIKey\"\
>here</a>. The key is optional - however the API is heavily rate limited\
\ when using without API Key. Creating and using the API key therefore\
\ is recommended. The key is case sensitive."
airbyte_secret: true
urls:
type: "array"
items:
type: "string"
pattern: "^(?:origin:)?(http(s)?:\\/\\/)[\\w.-]+(?:\\.[\\w\\.-]+)+[\\\
w\\-\\._~:\\/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]+$"
title: "URLs to analyse"
description: "The URLs to retrieve pagespeed information from. The connector\
\ will attempt to sync PageSpeed reports for all the defined URLs. Format:\
\ https://(www.)url.domain"
example: "https://example.com"
strategies:
type: "array"
items:
type: "string"
enum:
- "desktop"
- "mobile"
title: "Analyses Strategies"
description: "The analyses strategy to use. Either \"desktop\" or \"mobile\"\
."
categories:
type: "array"
items:
type: "string"
enum:
- "accessibility"
- "best-practices"
- "performance"
- "pwa"
- "seo"
title: "Lighthouse Categories"
description: "Defines which Lighthouse category to run. One or many of:\
\ \"accessibility\", \"best-practices\", \"performance\", \"pwa\", \"\
seo\"."
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-google-search-console:0.1.18"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/google-search-console"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*
!Dockerfile
!main.py
!source_google_pagespeed_insights
!setup.py
!secrets
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
FROM python:3.9.11-alpine3.15 as base

# build and load all requirements
FROM base as builder
WORKDIR /airbyte/integration_code

# upgrade pip to the latest version
RUN apk --no-cache upgrade \
&& pip install --upgrade pip \
&& apk --no-cache add tzdata build-base


COPY setup.py ./
# install necessary packages to a temporary folder
RUN pip install --prefix=/install .

# build a clean environment
FROM base
WORKDIR /airbyte/integration_code

# copy all loaded and built libraries to a pure basic image
COPY --from=builder /install /usr/local
# add default timezone settings
COPY --from=builder /usr/share/zoneinfo/Etc/UTC /etc/localtime
RUN echo "Etc/UTC" > /etc/timezone

# bash is installed for more convenient debugging.
RUN apk --no-cache add bash

# copy payload code only
COPY main.py ./
COPY source_google_pagespeed_insights ./source_google_pagespeed_insights

ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.name=airbyte/source-google-pagespeed-insights
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
# Google Pagespeed Insights Source

This is the repository for the Google Pagespeed Insights configuration based source connector.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/google-pagespeed-insights).

## Local development

#### Building via Gradle
You can also build the connector in Gradle. This is typically used in CI and not needed for your development workflow.

To build using Gradle, from the Airbyte repository root, run:
```
./gradlew :airbyte-integrations:connectors:source-google-pagespeed-insights:build
```

#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/google-pagespeed-insights)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_google_pagespeed_insights/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source google-pagespeed-insights test creds`
and place them into `secrets/config.json`.

### Locally running the connector docker image

#### Build
First, make sure you build the latest Docker image:
```
docker build . -t airbyte/source-google-pagespeed-insights:dev
```

You can also build the connector image via Gradle:
```
./gradlew :airbyte-integrations:connectors:source-google-pagespeed-insights:airbyteDocker
```
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in
the Dockerfile.

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-google-pagespeed-insights:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-google-pagespeed-insights:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-google-pagespeed-insights:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-google-pagespeed-insights:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing

#### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.

To run your integration tests with docker

### Using gradle to run tests
All commands should be run from airbyte project root.
To run unit tests:
```
./gradlew :airbyte-integrations:connectors:source-google-pagespeed-insights:unitTest
```
To run acceptance and custom integration tests:
```
./gradlew :airbyte-integrations:connectors:source-google-pagespeed-insights:integrationTest
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests.
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)).
1. Create a Pull Request.
1. Pat yourself on the back for being an awesome contributor.
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-google-pagespeed-insights:dev
acceptance_tests:
spec:
tests:
- spec_path: "source_google_pagespeed_insights/spec.yaml"
connection:
tests:
- config_path: "secrets/config.json"
status: "succeed"
timeout_seconds: 120
- config_path: "integration_tests/invalid_config.json"
status: "failed"
timeout_seconds: 120
discovery:
tests:
- config_path: "secrets/config.json"
basic_read:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []
# Using expect_records we can make sure that our "categories-array" spec
# really works and produces multiple category request params
expect_records:
path: "integration_tests/expected_records.json"
extra_fields: yes
exact_order: yes
extra_records: no
incremental:
bypass_reason: "This connector does not implement incremental sync"
full_refresh:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
pagespeed: ["lighthouseResult", "analysisUTCTimestamp"] # This differs between two runs, as they are newly generated per run
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env sh

# Build latest connector image
docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2-)

# Pull latest acctest image
docker pull airbyte/source-acceptance-test:latest

# Run
docker run --rm -it \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /tmp:/tmp \
-v $(pwd):/test_input \
airbyte/source-acceptance-test \
--acceptance-test-config /test_input

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_google_pagespeed_insights'
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("source_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
"""This fixture is a placeholder for external resources that acceptance test might require."""
yield
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"streams": [
{
"stream": {
"name": "pagespeed",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"stream": "pagespeed", "data": { "captchaResult": "CAPTCHA_NOT_NEEDED", "kind": "pagespeedonline#result", "lighthouseResult": { "configSettings": { "onlyCategories": ["pwa", "performance"] }, "categories": { "performance": { "id": "performance" }, "pwa": { "id": "pwa" } } }}, "emitted_at": 1626172757000}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"api_key": "invalid_key",
"urls": ["https://www.vol.at", "https://www.vienna.at"],
"strategies": ["desktop", "mobile"],
"categories": ["performance", "pwa"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"api_key": "sample",
"urls": ["https://www.vol.at", "https://www.vienna.at"],
"strategies": ["desktop", "mobile"],
"categories": ["performance", "pwa"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


import sys

from airbyte_cdk.entrypoint import launch
from source_google_pagespeed_insights import SourceGooglePagespeedInsights

if __name__ == "__main__":
source = SourceGooglePagespeedInsights()
launch(source, sys.argv[1:])
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-e ../../bases/source-acceptance-test
-e .
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.1",
]

TEST_REQUIREMENTS = [
"pytest~=6.1",
"pytest-mock~=3.6.1",
"source-acceptance-test",
]

setup(
name="source_google_pagespeed_insights",
description="Source implementation for Google Pagespeed Insights.",
author="Airbyte",
author_email="contact@airbyte.io",
packages=find_packages(),
install_requires=MAIN_REQUIREMENTS,
package_data={"": ["*.json", "*.yaml", "schemas/*.json", "schemas/shared/*.json"]},
extras_require={
"tests": TEST_REQUIREMENTS,
},
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#
# Copyright (c) 2022 Airbyte, Inc., all rights reserved.
#


from .source import SourceGooglePagespeedInsights

__all__ = ["SourceGooglePagespeedInsights"]
Loading

0 comments on commit b6c6b7a

Please sign in to comment.