Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
  • Loading branch information
@grubberr
grubberr committed Apr 26, 2022
1 parent 75d044f commit bb091f2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-github/unit_tests/test_stream.py
View file
Expand Up @@ -48,7 +48,7 @@
def test_internal_server_error_retry(time_mock):
args = {"authenticator": None, "repositories": ["test_repo"], "start_date": "start_date", "page_size_for_large_streams": 30}
stream = PullRequestCommentReactions(**args)
stream_slice = {"repository": "test_repo", "id": "id"}
stream_slice = {"repository": "test_repo", "comment_id": "id"}

time_mock.reset_mock()
responses.add(
Expand Down

1 comment on commit bb091f2

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Source Github(#12294)

Measures

Name Value Name Value Name Value
Quality Gate Status ERROR Bugs 0 Lines of Code 984
Vulnerabilities 0 Coverage 47.4 Duplicated Lines (%) 26.0
Duplicated Blocks 10 Code Smells 4 Reliability Rating A
Lines to Cover 38 Security Rating A Blocker Issues 0
Critical Issues 2 Major Issues 2 Minor Issues 0

Detected Issues

Rule File Description Message
python:S3776 (CRITICAL) source_github/streams.py:90 Cognitive Complexity of functions should not be too high Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
python:S5886 (MAJOR) source_github/streams.py:83 Function return types should be consistent with their type hint Return a value of type "Union[int, float]" instead of "NoneType" or update function "backoff_time" type hint.
python:S5797 (CRITICAL) fixtures/github.py:79 Constants should not be used as conditions Replace this expression; used as a condition it will always be constant.
python:S112 (MAJOR) source_github/source.py:77 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.

Coverage (47.4%)

File Coverage File Coverage
fixtures/github.py 0.0 fixtures/main.py 0.0
source_github/init.py 100.0 source_github/source.py 70.7
source_github/streams.py 91.4

Please sign in to comment.