Skip to content

Commit

Permalink
More destination fixes for ci_check_dependency (#20274)
Browse files Browse the repository at this point in the history
  • Loading branch information
evantahler committed Dec 9, 2022
1 parent abee21e commit c948331
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
2 changes: 2 additions & 0 deletions docs/integrations/destinations/redpanda.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ More info about this can be found in the [Redpanda producer configs documentatio

_NOTE_: Configurations for SSL are not available yet.

## CHANGELOG

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------- |
| 0.1.0 | 2022-08-05 | [18884](https://github.com/airbytehq/airbyte/pull/18884) | Initial commit |
11 changes: 6 additions & 5 deletions tools/bin/ci_check_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,14 @@ def get_connector_version_status(connector, version):


def get_connector_changelog_status(connector: str, version) -> str:
type, name = connector.replace("-strict-encrypt", "").split("-", 1)
type, name = connector.replace("-strict-encrypt", "").replace("-denormalized", "").split("-", 1)
doc_path = f"{DOC_PATH}{type}s/{name}.md"

if any(regex.match(connector) for regex in IGNORED_DESTINATIONS):
return "🔵<br/>(ignored)"
if not os.path.exists(doc_path):
return "⚠<br/>(doc not found)"

with open(doc_path) as f:
after_changelog = False
for line in f:
Expand All @@ -139,10 +143,7 @@ def get_connector_changelog_status(connector: str, version) -> str:
if after_changelog and version in line:
return "✅"

if any(regex.match(connector) for regex in IGNORED_DESTINATIONS):
return "🔵<br/>(ignored)"
else:
return "❌<br/>(changelog missing)"
return "❌<br/>(changelog missing)"


def as_bulleted_markdown_list(items):
Expand Down

0 comments on commit c948331

Please sign in to comment.